Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing unit type resets after saving listing as a draft #1897

Closed
dominikx96 opened this issue Sep 29, 2021 · 1 comment
Closed

Listing unit type resets after saving listing as a draft #1897

dominikx96 opened this issue Sep 29, 2021 · 1 comment
Assignees
@pbn4
Labels
bug Something isn't working

Comments

@dominikx96
Copy link
Collaborator

After filling the listing mgmt form, all values from the "UNIT TYPE" columns are empty:

Partners Portal 2021-09-29 at 5 02 55 PM
@dominikx96 dominikx96 added the bug Something isn't working label Sep 29, 2021
@dominikx96 dominikx96 self-assigned this Sep 29, 2021
@dominikx96 dominikx96 mentioned this issue Sep 29, 2021
Closed
@dominikx96
Copy link
Collaborator Author

@pbn4 I did an investigation and it looks like UnitCreate interface includes UnitTypeCreate interface what is wrong.
We have all unit types from the /unitTypes endpoint, so UnitCreate interface should contain unitType?: Id, instead of UnitTypeCreate

@dominikx96 dominikx96 assigned pbn4 and unassigned dominikx96 Sep 30, 2021
pbn4 added a commit that referenced this issue Oct 7, 2021
@pbn4
fix(backend): unitCreate and UnitUpdateDto now require only IdDto for…
5369dba 
… related properties

Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change
@pbn4 pbn4 mentioned this issue Oct 7, 2021
Merged
28 tasks
pbn4 added a commit that referenced this issue Oct 7, 2021
@pbn4
fix(backend): unitCreate and UnitUpdateDto now require only IdDto for…
5dc3f8d 
… related properties

Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change
seanmalbert added a commit that referenced this issue Oct 12, 2021
@pbn4 @seanmalbert @lint-action
fix(backend): unitCreate and UnitUpdateDto now require only IdDto for… (
43dcfbe 
#1956)

* fix(backend): unitCreate and UnitUpdateDto now require only IdDto for related properties

Related to #1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change

* fix: updates ui component version

* Fix code style issues with Prettier

* fix(backend-swagger): manually add totalFlagged until fixed

Co-authored-by: Sean Albert <[email protected]>
Co-authored-by: Lint Action <[email protected]>
@slowbot slowbot closed this as completed Oct 13, 2021
@kathyccheng kathyccheng mentioned this issue Oct 13, 2021
Closed
seanmalbert added a commit to CityOfDetroit/bloom that referenced this issue Jun 23, 2022
@pbn4 @seanmalbert @lint-action
fix(backend): unitCreate and UnitUpdateDto now require only IdDto for… (
209dd48 
bloom-housing#1956)

* fix(backend): unitCreate and UnitUpdateDto now require only IdDto for related properties

Related to bloom-housing#1897, UnitCreateDto specified UnitTypeCreateDto as an input and as a result (no id
provided) it created a new unit type on each form submission.

BREAKING CHANGE: POST/PUT /listings interface change

* fix: updates ui component version

* Fix code style issues with Prettier

* fix(backend-swagger): manually add totalFlagged until fixed

Co-authored-by: Sean Albert <[email protected]>
Co-authored-by: Lint Action <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbn4 pbn4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slowbot @pbn4 @dominikx96