Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile menu coming from the top instead of the side #1467

Closed
akegan opened this issue Jul 2, 2021 · 3 comments
Closed

Mobile menu coming from the top instead of the side #1467

akegan opened this issue Jul 2, 2021 · 3 comments
Assignees
Labels
sf request Changes requested by the DAHLIA team

Comments

@akegan
Copy link
Contributor

akegan commented Jul 2, 2021

We just did a visual design review of our react homepage ahead of launch, and the design team found some design issues that they marked as blockers for deploy.

They had a couple of different pieces of feedback about the menu:

1. Different menus across different pages could be confusing

They noted that since we're going to be in a mixed state of angular and react pages for some time, that it might be confusing for users to have two different mobile menu experiences on different pages.

Did you consider keeping the same style of menu we had on DAHLIA where it came out from the side as a drawer? Were there technical limitations that prevented you from implementing it? Would you be open to switching to a drawer component that's more similar to what we have for DAHLIA if we contribute it?
Mobile menu

2. Mobile menu pushes down content instead of sitting on top of it

(see image above). One designer noticed that the menu pushes down the content instead of unfurling on top of it and thought it was a bit strange. Was that an intentional choice? or a technical limitation?

cc @emilyshore

@akegan akegan added the sf request Changes requested by the DAHLIA team label Jul 2, 2021
@akegan
Copy link
Contributor Author

akegan commented Jul 6, 2021

Could add an option to menubar to make it a drawer instead. Could be related to #1345.

We might also need to look into a11y on the mobile navbar to make sure that the focus works as expected.

Exygy folks are up for doing it as an overlay instead of pushing the content down.

Edit: goal is to keep the same component.

@akegan
Copy link
Contributor Author

akegan commented Jul 6, 2021

Next step is to write a unified story about desktop/mobile navbar and layout options.

@slowbot
Copy link
Collaborator

slowbot commented Jul 15, 2021

@akegan Starting to sketch the component and options for nav https://www.figma.com/file/tUtgsJO8XnF9Ij2dwu22EF/bloom-general?node-id=387%3A768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Development

No branches or pull requests

3 participants