-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing Bulma for navbar, writing our own #1345
Comments
Sounds good to me. We added Bulma originally for a quick leg up, but it's clearer by now what sorts of features we'll want and the best way to achieve them. |
QA the entire SiteHeader (including the language nav, feedback bar, logo, and navbar links) on both mobile and desktop and ensure it is keyboard accessible |
Can you re-assign me issues when they're kicked back to QA? Otherwise they really easily get lost :) Thanks! |
@seanmalbert @emilyjablonski Lets talk about the process. Not sure if its best to reassign or put it at the top of the stack for whomever to pick up. I try to at least comment the original engineer but see I forgot to do that here. |
QA: All three of the above visual issues |
Due to some new feature requests in the navbar, maintaining our use of Bulma has become more challenging.
There are changes we want to make that Bulma does not easily support (like custom logo widths and image-only logos) that are possible for us now but require quite a bit of CSS overriding to remove their default styles.
We also currently have an untranslated string "Menu" that we add in the CSS because Bulma doesn't support text there out of the box.
I think it would be cleaner and easier in the long run to remove Bulma and write our own nav bar so we have full control and customization.
Visual Mockups
https://www.figma.com/file/tUtgsJO8XnF9Ij2dwu22EF/bloom-general?node-id=387%3A768
The text was updated successfully, but these errors were encountered: