Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing Bulma for navbar, writing our own #1345

Closed
emilyjablonski opened this issue Jun 9, 2021 · 6 comments
Closed

Consider removing Bulma for navbar, writing our own #1345

emilyjablonski opened this issue Jun 9, 2021 · 6 comments
Assignees

Comments

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Jun 9, 2021

Due to some new feature requests in the navbar, maintaining our use of Bulma has become more challenging.

There are changes we want to make that Bulma does not easily support (like custom logo widths and image-only logos) that are possible for us now but require quite a bit of CSS overriding to remove their default styles.

We also currently have an untranslated string "Menu" that we add in the CSS because Bulma doesn't support text there out of the box.

I think it would be cleaner and easier in the long run to remove Bulma and write our own nav bar so we have full control and customization.

Visual Mockups
https://www.figma.com/file/tUtgsJO8XnF9Ij2dwu22EF/bloom-general?node-id=387%3A768

@jaredcwhite
Copy link
Collaborator

Sounds good to me. We added Bulma originally for a quick leg up, but it's clearer by now what sorts of features we'll want and the best way to achieve them.

@emilyjablonski
Copy link
Collaborator Author

QA the entire SiteHeader (including the language nav, feedback bar, logo, and navbar links) on both mobile and desktop and ensure it is keyboard accessible

@slowbot
Copy link
Collaborator

slowbot commented Oct 7, 2021

A couple of small bugs

  1. Some menu items do not extend full width of dropdown
    image

  2. There is a 1px jog up and down on hover of Sign Out button on partners
    image
    image

  3. Partner menu needs to be a wider width
    image

@slowbot slowbot added the failed qa This issue or pull request already exists label Oct 7, 2021
@slowbot slowbot removed their assignment Oct 7, 2021
@emilyjablonski
Copy link
Collaborator Author

Can you re-assign me issues when they're kicked back to QA? Otherwise they really easily get lost :) Thanks!

@emilyjablonski emilyjablonski self-assigned this Oct 14, 2021
@slowbot
Copy link
Collaborator

slowbot commented Oct 15, 2021

@seanmalbert @emilyjablonski Lets talk about the process. Not sure if its best to reassign or put it at the top of the stack for whomever to pick up. I try to at least comment the original engineer but see I forgot to do that here.

@emilyjablonski emilyjablonski added ready for qa Ready to be QA’d and removed code quality / devops / build ready for qa Ready to be QA’d failed qa This issue or pull request already exists sf request Changes requested by the DAHLIA team labels Oct 15, 2021
@emilyjablonski
Copy link
Collaborator Author

QA: All three of the above visual issues

@slowbot slowbot removed the ready for qa Ready to be QA’d label Oct 21, 2021
@slowbot slowbot closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants