Add AmiChart overriding logic tests

backend/core/src/listings/listings.service.spec.ts

@@ -6,6 +6,7 @@ import { Listing } from "./entities/listing.entity"
 import { ListingsQueryParams, ListingFilterParams } from "./dto/listing.dto"
 import { Compare } from "../shared/dto/filter.dto"
 import { TranslationsService } from "../translations/translations.service"
+import { AmiChart } from "../ami-charts/entities/ami-chart.entity"
 
 // Cypress brings in Chai types for the global expect, but we want to use jest
 // expect here so we need to re-declare it.
@@ -102,6 +103,10 @@ describe("ListingsService", () => {
           provide: getRepositoryToken(Listing),
           useValue: mockListingsRepo,
         },
+        {
+          provide: getRepositoryToken(AmiChart),
+          useValue: jest.fn(),
+        },
         {
           provide: TranslationsService,
           useValue: { translateListing: jest.fn() },

backend/core/src/listings/views/view.spec.ts

@@ -59,7 +59,7 @@ describe("listing views", () => {
       view.getViewQb()
 
       expect(mockQueryBuilder.select).toHaveBeenCalledTimes(1)
-      expect(mockQueryBuilder.leftJoin).toHaveBeenCalledTimes(7)
+      expect(mockQueryBuilder.leftJoin).toHaveBeenCalledTimes(8)
     })
 
     it("should map unitSummary to listings", () => {

backend/core/src/shared/units-transformations.spec.ts

@@ -0,0 +1,49 @@
+import { AmiChart } from "../ami-charts/entities/ami-chart.entity"
+import { UnitAmiChartOverride } from "../units/entities/unit-ami-chart-override.entity"
+import { mergeAmiChartWithOverrides } from "./units-transformations"
+
+describe("Unit Transformations", () => {
+  it("Ami chart items are correctly overwritten", () => {
+    let amiChart: AmiChart = {
+      id: "id",
+      createdAt: new Date(),
+      updatedAt: new Date(),
+      name: "name",
+      items: [
+        {
+          percentOfAmi: 1,
+          householdSize: 1,
+          income: 1,
+        },
+        {
+          percentOfAmi: 2,
+          householdSize: 2,
+          income: 2,
+        },
+        {
+          percentOfAmi: 3,
+          householdSize: 3,
+          income: 3,
+        },
+      ],
+    }
+
+    const amiChartOverride: UnitAmiChartOverride = {
+      id: "id",
+      createdAt: new Date(),
+      updatedAt: new Date(),
+      items: [
+        {
+          percentOfAmi: 2,
+          householdSize: 2,
+          income: 20,
+        },
+      ],
+    }
+    amiChart = mergeAmiChartWithOverrides(amiChart, amiChartOverride)
+    expect(amiChart.items.length).toBe(3)
+    expect(amiChart.items[0].income).toBe(1)
+    expect(amiChart.items[1].income).toBe(20)
+    expect(amiChart.items[2].income).toBe(3)
+  })
+})

backend/core/src/shared/units-transformations.ts

@@ -39,10 +39,10 @@ const getAmiChartItemUniqueKey = (amiChartItem: AmiChartItem) => {
   return amiChartItem.householdSize.toString() + "-" + amiChartItem.percentOfAmi.toString()
 }
 
-const mergeAmiChartWithOverrides = (amiChart: AmiChart, override: UnitAmiChartOverride) => {
+export const mergeAmiChartWithOverrides = (amiChart: AmiChart, override: UnitAmiChartOverride) => {
   const householdAmiPercentageOverrideMap: Map<string, AmiChartItem> = override.items.reduce(
     (acc, amiChartItem) => {
-      acc[getAmiChartItemUniqueKey(amiChartItem)] = amiChartItem
+      acc.set(getAmiChartItemUniqueKey(amiChartItem), amiChartItem)
       return acc
     },
     new Map()

backend/core/test/listings/listings.e2e-spec.ts

@@ -177,7 +177,6 @@ describe("Listings", () => {
     const am: ApplicationMethodCreateDto = {
       type: ApplicationMethodType.FileDownload,
       paperApplications: [{ id: paperApplication.body.id }],
-      listing: listing,
     }
 
     const applicationMethod = await supertest(app.getHttpServer())