Make list of market configuration driven instead of hard coded. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2022 11:21
… client library versions.Read markets from Mango (or Serum) config files instead of hard coded list.
mschneider
reviewed
Jun 28, 2022
package.json
Outdated
| "@solana/web3.js": "^0.91.0", | ||
| "axios": "^0.21.1", | ||
| "cors": "^2.8.5", | ||
| "dayjs": "^1.10.7", | ||
| "express": "^4.17.1", | ||
| "lru-cache": "^5.1.0", | ||
| "npm-run-all": "^4.1.5", |
There was a problem hiding this comment.
Why do we need a new package here? I don’t see it used anywhere
There was a problem hiding this comment.
Good question. I wasn't able to run the script "prepare": "run-s clean postinstall". run-s is part of the npm-run-all package. Couldn't we change the "prepare" script to "npm run clean && npm run postinstall" and remove run-s/npm-run-all as a dependency?
|
My 2 cents on this issue:
Both are not really actionable comments, happy to merge this nevertheless, but wanted to mention those concerns. |
|
For #2, I added back the ability to specify a list of markets for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read spot markets from Mango (or Serum) config files in client libraries instead of hard coded. Users can now implement their own configuration scheme.
Updated mango and serum client library versions to get the latest configuration files.
Updated README with some installation instructions.