Adding history module and implementing inmemory block storage and mix… #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godmodegalactus
requested review from
aniketfuryrocks and
grooviegermanikus
grooviegermanikus
requested changes
Sep 20, 2023
| pub struct MultipleStrategyBlockStorage { | ||
| inmemory_for_storage: InmemoryBlockStore, // for confirmed blocks | ||
| persistent_block_storage: BlockStorageImpl, // for persistent block storage | ||
| faithful_rpc_client: Option<Arc<RpcClient>>, // to fetch legacy blocks from faithful |
There was a problem hiding this comment.
that should go somewhere else.
There was a problem hiding this comment.
Nah we want to fall back to faithful if the link is provided..
| .save(slot, block, commitment) | ||
| .await; | ||
| } | ||
| if slot > self.last_confirmed_slot.load(Ordering::Relaxed) { |
There was a problem hiding this comment.
could use compare_exchange
There was a problem hiding this comment.
compare exchange requires anyways to fetch the value and the value will be exchanged only if it is the same as current value which may add additional complexity.
godmodegalactus
force-pushed
the
implementing_history_for_blocks
branch
from
033f18c to
1418451
Compare
aniketfuryrocks
previously approved these changes
Sep 21, 2023
changes after groovies review
godmodegalactus
force-pushed
the
implementing_history_for_blocks
branch
from
8c9cd82 to
7ef29e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed storage