Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add right bitshift tests #95

Merged
merged 3 commits into from
Nov 7, 2024
Merged

test: Add right bitshift tests #95

merged 3 commits into from
Nov 7, 2024

Conversation

Syndamia
Copy link

@Syndamia Syndamia commented Oct 2, 2024

Add tests for >>. Note that all of them should be successful if our implementation was feature-complete.

@Syndamia
Copy link
Author

Syndamia commented Oct 2, 2024

Currently BLOCKED due to an upstream bug

@Syndamia Syndamia force-pushed the test/right-bitshift branch from 86369e1 to 0d23d86 Compare November 6, 2024 09:31
Upstream pushed a commit, fixing the right shift issues, so the crash
doesn't happen.
@Syndamia
Copy link
Author

Syndamia commented Nov 6, 2024

Upstream fixed the right shift bugs, and as of today's repo sync, >> works on nargo execute.

The force-push is me rebasing this branch. I executed all right shift tests and they all produced the same value as expected in Prover.toml. Thought a check by someone else will be appreciated.

@Syndamia Syndamia marked this pull request as ready for review November 6, 2024 11:13
@nickysn nickysn self-assigned this Nov 6, 2024
@nickysn
Copy link

nickysn commented Nov 6, 2024

Unfortunately, there's another test that fails now: plonky2_prove_success/right_shift_unsigned_const:

error: Internal Consistency Evaluators Errors: 

                    This is likely a bug. Consider opening an issue at https://github.com/noir-lang/noir/issues
  ┌─ /home/nickysn/code/repos/metacraft-labs/noir/test_programs/plonky2_prove_success/right_shift_unsigned_const/src/main.nr:1:1
  │
1 │ fn main(
  │ - ICE: \"PLONKY2 backend ICE error: mismatching arg types: Integer(16, false) and Field; instr: \\\"Binary(Binary { lhs: Id(0), rhs: Id(2), operator: Div })\\\"\"
  │
  = Call stack:
    1. /home/nickysn/code/repos/metacraft-labs/noir/test_programs/plonky2_prove_success/right_shift_unsigned_const/src/main.nr:5:10

Error: Aborting due to 1 previous error

Possibly something has changed inside the compiler, that makes it fail, since I assume it used to work before. So, it's a known failure and per our policy, should be moved to plonky2_prove_crash, until we fix it in the plonky2 backend.

@Syndamia
Copy link
Author

Syndamia commented Nov 7, 2024

Good catch, I had forgotten there was a test inside plonky2_prove_success

@nickysn
Copy link

nickysn commented Nov 7, 2024

LGTM

@nickysn nickysn merged commit abe383d into blocksense Nov 7, 2024
2 checks passed
@nickysn nickysn deleted the test/right-bitshift branch November 7, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants