Improve locks acquiring #7947
Merged
Improve locks acquiring #7947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qwerty5Uiop
force-pushed
the
soften-locks
branch
from
d1824a3 to
455d0d1
Compare
vbaranov
approved these changes
Jul 19, 2023
sl1depengwyn
approved these changes
Jul 19, 2023
Qwerty5Uiop
force-pushed
the
soften-locks
branch
from
6878381 to
f4cf9c5
Compare
Qwerty5Uiop
force-pushed
the
soften-locks
branch
from
f4cf9c5 to
a414aaa
Compare
rkachowski
added a commit
to celo-org/blockscout
that referenced
this pull request
Aug 28, 2023
rkachowski
added a commit
to celo-org/blockscout
that referenced
this pull request
Sep 5, 2023
rkachowski
added a commit
to celo-org/blockscout
that referenced
this pull request
Sep 6, 2023
rkachowski
added a commit
to celo-org/blockscout
that referenced
this pull request
Sep 6, 2023
* cherry-pick -m 1 41f562b * Remove withdrawals tabel from migration (we dont' have it) * Apply changes from blockscout#7947 to reduce lock strength * Fix empty block sanitiser parsing. * Sort coin_balance fetcher address imports by hash. * Skipping flaky test. * Explicitly set lock_timeout for address import / insertion. * Revert "Explicitly set lock_timeout for address import / insertion." This reverts commit 7df9785. * Remove schema migration files from PR. --------- Co-authored-by: Victor Baranov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6755
Resolves #6734
Motivation
Currently we are using
FOR UPDATElocks in every lock queries, but there is no need to use this lock type for queries that are not going to delete or modify primary key. In these cases it's better to useFOR NO KEY UPDATEto avoid unnecessary locks.Also, there are several locks that hold data not meant to be updated.
Changelog
FOR UPDATEtoFOR NO KEY UPDATEfor queries that are not going to delete data or modify PKBlocksandCurrentTokenBalancesrunners to update token holders function since this lock is only needed for insert orderingEmptyBlockSanitizerso it doesn't conflict with general block fetchers