Skip to content

Commit

Permalink
Alphabetic sorting of event types in event filter (#740)
Browse files Browse the repository at this point in the history
* Alphabetic sorting of event type in event filter

* Update app version

---------

Co-authored-by: Anders Barfod <[email protected]>
  • Loading branch information
baffioso and Anders Barfod authored Sep 5, 2024
1 parent 4d06923 commit 475d245
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions apps/studieby/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ android {
applicationId "dev.blockparty.studieby"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 8
versionName "8"
versionCode 9
versionName "9"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
aaptOptions {
// Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps.
Expand Down
8 changes: 4 additions & 4 deletions apps/studieby/ios/App/App.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -497,12 +497,12 @@
CODE_SIGN_ENTITLEMENTS = App/App.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 8;
CURRENT_PROJECT_VERSION = 9;
DEVELOPMENT_TEAM = V3R5BRX963;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 8;
MARKETING_VERSION = 9;
OTHER_SWIFT_FLAGS = "$(inherited) \"-D\" \"COCOAPODS\" \"-DDEBUG\"";
PRODUCT_BUNDLE_IDENTIFIER = dev.blockparty.studieby;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -525,12 +525,12 @@
CODE_SIGN_ENTITLEMENTS = App/App.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 8;
CURRENT_PROJECT_VERSION = 9;
DEVELOPMENT_TEAM = V3R5BRX963;
INFOPLIST_FILE = App/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
MARKETING_VERSION = 8;
MARKETING_VERSION = 9;
PRODUCT_BUNDLE_IDENTIFIER = dev.blockparty.studieby;
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ export class EventFilterStateService {
.filter(
(eventType, index, eventTypes) =>
eventTypes.findIndex((v2) => v2.id === eventType.id) === index,
),
)
// TODO: create rank column for ordering event types by priority
.sort((a, b) => a.name.localeCompare(b.name)),
),
shareReplay(1),
);
Expand Down

0 comments on commit 475d245

Please sign in to comment.