Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-blocklet): validate project name compliance before creation #373

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix(create-blocklet): validate project name compliance before creation #373

merged 2 commits into from
Dec 2, 2024

Conversation

zhuzhuyule
Copy link
Contributor

Relates Issue

Main changes

  1. enhance project name creation with auto-formatting for validity
  2. validate project name compliance before creation

Screenshots

image
image

Check list

  • Project create by create-blocklet can work with npm run dev
  • Project create by create-blocklet can work with npm run deploy
  • Project create by create-blocklet can work with npm run upload
  • If a new version need to be publish, make sure you have run npm run bump-version command

@zhuzhuyule zhuzhuyule merged commit bc58969 into main Dec 2, 2024
4 checks passed
@zhuzhuyule zhuzhuyule deleted the fix/name-validate branch December 2, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LancelotLewis LancelotLewis LancelotLewis approved these changes

@wangshijun wangshijun Awaiting requested review from wangshijun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhuzhuyule @LancelotLewis