Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite-plugin-blocklet): should not use top await with export #355

Merged
merged 4 commits into from
Aug 27, 2024
Merged

fix(vite-plugin-blocklet): should not use top await with export #355

merged 4 commits into from
Aug 27, 2024

Conversation

LancelotLewis
Copy link
Collaborator

Relates Issue

relates https://github.com/ArcBlock/blocklet-server/issues/9687

Main changes

  1. Fixed top await & export cause error in chrome v128
  2. Improved templates, pass HTTP server instance to setupClient

Screenshots

Check list

  • Project create by create-blocklet can work with npm run dev
  • Project create by create-blocklet can work with npm run deploy
  • Project create by create-blocklet can work with npm run upload
  • If a new version need to be publish, make sure you have run npm run bump-version command

@LancelotLewis LancelotLewis merged commit d016ef4 into main Aug 27, 2024
4 checks passed
@LancelotLewis LancelotLewis deleted the fix-top-await branch August 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-yechao li-yechao Awaiting requested review from li-yechao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LancelotLewis