Merge pull request ethereum-optimism#86 from ethstorage/fix_warning

fix `just build` warning and last error
blockchaindevsh · Nov 5, 2024 · 7fc9d14 · 7fc9d14
2 parents a8c36a3 + 22af1e1
commit 7fc9d14
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/packages/contracts-bedrock/scripts/checks/interfaces/main.go b/packages/contracts-bedrock/scripts/checks/interfaces/main.go
@@ -29,6 +29,7 @@ var excludeContracts = []string{
 	"IInitializable", "ILegacyMintableERC20", "IOptimismMintableERC20",
 	"IOptimismMintableERC721", "KontrolCheatsBase", "IWETH", "IDelayedWETH", "ISuperchainWETH",
 	"IL2ToL2CrossDomainMessenger", "ICrossL2Inbox", "ISystemConfigInterop", "IResolvedDelegateProxy",
+	"IERC20Upgradeable",
 }
 
 type ContractDefinition struct {

diff --git a/packages/contracts-bedrock/src/L2/L1Block.sol b/packages/contracts-bedrock/src/L2/L1Block.sol
@@ -209,7 +209,7 @@ contract L1Block is ISemver, IGasToken {
     }
 
     /// @notice Returns the size of history hashes.
-    function historySize() external view returns (uint256) {
+    function historySize() external pure returns (uint256) {
         return HISTORY_SIZE;
     }
 }
diff --git a/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol b/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol
@@ -39,6 +39,6 @@ interface IL1Block {
 
     function __constructor__() external;
 
-    function historySize() external view returns (uint256);
+    function historySize() external pure returns (uint256);
     function blockHash(uint256 _historyNumber) external view returns (bytes32);
 }
diff --git a/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol b/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol
@@ -58,6 +58,6 @@ interface IL1BlockInterop {
 
     function __constructor__() external;
 
-    function historySize() external view returns (uint256);
+    function historySize() external pure returns (uint256);
     function blockHash(uint256 _historyNumber) external view returns (bytes32);
 }