Feature/PL-bug-fixes #388
Merged
Feature/PL-bug-fixes #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plondon
force-pushed
the
feature/PL-bug-fixes
branch
from
092f393 to
9156291
Compare
| @@ -8,7 +8,7 @@ import SelectBoxBitcoin from './template' | |||
|
|
|||
| class SelectBoxBitcoinAddresses extends React.PureComponent { | |||
| getLabel (coin) { | |||
| return `All Bitcoin${coin === 'BCH' ? ' Cash' : ''} Wallets` | |||
| return this.props.optional ? 'N/A' : `All Bitcoin${coin === 'BCH' ? ' Cash' : ''} Wallets` | |||
There was a problem hiding this comment.
Why would you want to display 'N/A'
There was a problem hiding this comment.
For importing external btc addrs, there needs to be an option to deselect if you've made a selection.
| } | ||
|
|
||
| const mapStateToProps = (state, ownProps) => ({ | ||
| data: getData(state, ownProps.coin) | ||
| data: getData(state, ownProps) |
There was a problem hiding this comment.
If you do this, also replace the argument coin with props in the getData function
| @@ -19,20 +19,21 @@ export const getData = (state, coin) => { | |||
| return map(formatAddress, addressesData) | |||
| } | |||
|
|
|||
| const getAddressesData = (coin) => { | |||
| const getAddressesData = (ownProps) => { | |||
There was a problem hiding this comment.
This change should be on getData used in index.js, not getAddressesData used in selectors.js
There was a problem hiding this comment.
Good point, also turns out defaultProps are not passed in ownProps so I need to change this.
|
@sixtedemaupeou issues should be fixed now. I add a |
sixtedemaupeou
approved these changes
May 9, 2018
This was referenced May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a concise explanation of the changes.
Change Type
Please enter one or more of the following:
Testing Steps
Detail the steps required for the reviewer(s) to verify and test these changes.
PR Creator Checklist
yarn lint)yarn test)README.mdand other documentation (if necessary)PR Reviewer Checklist