feat(BCH): add bch to currency balance stats

blockchain · Nov 29, 2017 · 5ace69a · 1Bennell · Jul 29, 2018 · 1Bennell
1 parent cfdec32
commit 5ace69a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/src/api.js b/src/api.js
@@ -308,10 +308,10 @@ API.prototype.incrementLoginViaQrStats = function () {
   return fetch(this.ROOT_URL + 'event?name=wallet_web_login_via_qr');
 };
 
-API.prototype.incrementBtcEthUsageStats = function (btcBalance, ethBalance) {
+API.prototype.incrementCurrencyUsageStats = function (btcBalance, ethBalance, bchBalance) {
   let base = this.ROOT_URL + 'event?name=wallet_login_balance';
-  let makeEventUrl = (btc, eth) => `${base}_btc_${btc ? 1 : 0}_eth_${eth ? 1 : 0}`;
-  fetch(makeEventUrl(btcBalance > 0, ethBalance > 0));
+  let makeEventUrl = (btc, eth, bch) => `${base}_btc_${btc ? 1 : 0}_eth_${eth ? 1 : 0}_bch_${bch ? 1 : 0}`;
+  fetch(makeEventUrl(btcBalance > 0, ethBalance > 0, bchBalance > 0));
 };
 
 API.prototype.getPriceChartData = function (params) {

diff --git a/tests/api.spec.js b/tests/api.spec.js
@@ -19,36 +19,41 @@ describe('API', () => {
     });
   });
 
-  describe('.incrementBtcEthUsageStats', () => {
+  describe('.incrementCurrencyUsageStats', () => {
     let eventUrl = (event) => `https://blockchain.info/event?name=wallet_login_balance_${event}`
 
     beforeEach(() => {
       spyOn(window, 'fetch')
     })
 
     it('should make one request', () => {
-      API.incrementBtcEthUsageStats(0, 0)
+      API.incrementCurrencyUsageStats(0, 0)
       expect(window.fetch).toHaveBeenCalledTimes(1)
     })
 
     it('should record correctly for btc=0, eth=0', () => {
-      API.incrementBtcEthUsageStats(0, 0)
-      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_0_eth_0'))
+      API.incrementCurrencyUsageStats(0, 0)
+      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_0_eth_0_bch_0'))
     })
 
     it('should record correctly for btc>0, eth=0', () => {
-      API.incrementBtcEthUsageStats(1, 0)
-      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_1_eth_0'))
+      API.incrementCurrencyUsageStats(1, 0)
+      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_1_eth_0_bch_0'))
     })
 
     it('should record correctly for btc=0, eth>0', () => {
-      API.incrementBtcEthUsageStats(0, 1)
-      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_0_eth_1'))
+      API.incrementCurrencyUsageStats(0, 1)
+      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_0_eth_1_bch_0'))
     })
 
     it('should record correctly for btc>0, eth>0', () => {
-      API.incrementBtcEthUsageStats(1, 1)
-      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_1_eth_1'))
+      API.incrementCurrencyUsageStats(1, 1)
+      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_1_eth_1_bch_0'))
+    })
+
+    it('should record correctly for bch>0', () => {
+      API.incrementCurrencyUsageStats(0, 0, 1)
+      expect(window.fetch).toHaveBeenCalledWith(eventUrl('btc_0_eth_0_bch_1'))
     })
   })
 });