feat: implement the core build engine #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
alecthomas
force-pushed
the
aat/implement-build-engine
branch
from
81f980e to
ec1c421
Compare
alecthomas
commented
Feb 26, 2024
| @@ -132,3 +132,5 @@ issues: | |||
| - 'should have comment \(or a comment on this block\) or be unexported' | |||
| - caseOrder | |||
| - unused-parameter | |||
| - "^loopclosure:" | |||
There was a problem hiding this comment.
We're on Go 1.22 now, which eliminates this issue.
alecthomas
force-pushed
the
aat/implement-build-engine
branch
3 times, most recently
from
89f7fbf to
2761a5a
Compare
This brings all of the existing buildengine utilities together into a single system that unifies schema changes from the FTL controller with local modules, supporting both online and completely offline builds. Builds are run in parallel, with dependencies preferencing schemas from other local modules first, then falling back on schemas from the FTL controller.
alecthomas
force-pushed
the
aat/implement-build-engine
branch
from
2761a5a to
66ee3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings all of the existing buildengine utilities together into a single system that unifies schema changes from the FTL controller with local modules, supporting both online and completely offline builds.
Builds are run in parallel, with dependencies preferencing schemas from other local modules first, then falling back on schemas from the FTL controller.
Dynamic module watching will be implemented in a followup.
Fixes #961
Fixes #985