chore: implement DataRef.schemaChildren() #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
wesbillman
reviewed
Feb 7, 2024
backend/schema/schema_test.go
Outdated
Comment on lines
58
to
60
| data Generic<T> { | ||
| value T | ||
| } |
There was a problem hiding this comment.
Do we not want to test this still? How do we know if the imports are correct now?
There was a problem hiding this comment.
Ah whoops you're right! Got too enthusiastic with git revert!
There was a problem hiding this comment.
Restored that and added another test for verb references.
alecthomas
force-pushed
the
aat/fix-dataref-children
branch
2 times, most recently
from
3338b1d to
cc6b1d9
Compare
It was returning nil previously, resulting in the Visit() function never visiting the type parameters and all sorts of things failing!
alecthomas
force-pushed
the
aat/fix-dataref-children
branch
from
cc6b1d9 to
5fda2cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was returning nil previously, resulting in the Visit() function never visiting the type parameters and all sorts of things failing!