feat: use detekt to extract kotlin schema #549
Conversation
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
| } | ||
| calls.addAll(refs) | ||
|
|
||
| // Step into function calls inside this expression body to look for transitive calls. |
There was a problem hiding this comment.
cc @alecthomas extracting transitive calls
|
|
||
| private fun extractIngress(): MetadataIngress? { | ||
| return verb.annotationEntries.firstOrNull { | ||
| bindingContext.get(BindingContext.ANNOTATION, it)?.fqName?.asString() == Ingress::class.qualifiedName |
There was a problem hiding this comment.
A bit unfortunate that we can't get a reference to the concrete annotation class like we can with KSP :(
There was a problem hiding this comment.
yeah, there were some operations that were a lot more ergonomic with KSP :( one thing that's nice about detekt though it's it's a thin shim around kotlin PSI, which I found a lot more google-able than the KSP frameworks/schemas. so maybe easier to build on until KSP resources have improved a bit
also fwiw this is more verbose but should still be deterministic since we're comparing fully qualified class names
| calls.addAll(refs) | ||
|
|
||
| // Step into function calls inside this expression body to look for transitive calls. | ||
| body.children.mapNotNull { |
There was a problem hiding this comment.
Is this recursive, or just top-level calls? If the latter, fine for now but maybe add a note to remind us.
worstell
force-pushed
the
worstell/20231023-detekt
branch
from
af54e10 to
9ec86ef
Compare
fixes #530