Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use grpc client when calling schema service from controller #4198

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

jvmakine
Copy link
Contributor

@jvmakine jvmakine commented Jan 28, 2025

Adds a new endpoint for getting deployments to the schemaservice, and uses that in controller.
We will probably want to refactor this endpoint soon when we look at changesets.

This is a minimal change to get the controller to use the grpc client, any refactoring on the schema service APIs will follow after this.

@alecthomas alecthomas mentioned this pull request Jan 28, 2025
@jvmakine jvmakine marked this pull request as ready for review January 28, 2025 03:41
@jvmakine jvmakine requested review from a team and alecthomas as code owners January 28, 2025 03:41
@jvmakine jvmakine merged commit 3bfe2b3 into main Jan 28, 2025
67 checks passed
@jvmakine jvmakine deleted the juho/grpc-client branch January 28, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant