chore: use a single sumtype for all schema modifying events #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
jvmakine
force-pushed
the
juho/schema-events-to-one-place
branch
2 times, most recently
from
cd53968 to
6688e78
Compare
jvmakine
force-pushed
the
juho/schema-events-to-one-place
branch
2 times, most recently
from
de23100 to
c96e535
Compare
jvmakine
force-pushed
the
juho/schema-events-to-one-place
branch
from
c96e535 to
ca242ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies all schema changing operations in provisioner and controller to go through same events and interface.
The state in provisioner is still separate from controller for now. They should be easy to put together after this.
Changesets will change how the state is managed quite a bit, but should be easy to implement here