chore: pull out admin service #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
force-pushed
the
worstell/20241210-admin-service
branch
7 times, most recently
from
50b356a to
29c6f54
Compare
worstell
force-pushed
the
worstell/20241210-admin-service
branch
from
da3fa2c to
1d7666c
Compare
wesbillman
approved these changes
Dec 12, 2024
Comment on lines
+35
to
+39
| func (c *Config) SetDefaults() { | ||
| if err := kong.ApplyDefaults(c, kong.Vars{"dsn": dsn.PostgresDSN("ftl")}); err != nil { | ||
| panic(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
Do we want/need kong stuff in here? I wonder if we could do this kong work in the cli/cmd code. Then, we might be able to remove this from the service layer.
There was a problem hiding this comment.
i don't feel super strongly - i think we went with calling it in start to centralize the logic across invocations from CLI, wdyt? since the config fields are defined with default field tags it doesn't feel completely out of place to me in the service layer
Comment on lines
+43
to
+44
| var _ timelineconnect.TimelineServiceHandler = (*service)(nil) | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.