feat: add module update events #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/schema-module-events
branch
from
634c73d to
d3c8303
Compare
alecthomas
commented
Dec 3, 2024
| return nil, fmt.Errorf("could not get schemas: %w", err) | ||
| } | ||
| for deployment, module := range schemas { | ||
| if module.Name != req.Msg.Module { |
There was a problem hiding this comment.
This should use the deployment key at some point, but we don't have it in the schema runtime data yet.
alecthomas
force-pushed
the
aat/schema-module-events
branch
from
d3c8303 to
7089658
Compare
alecthomas
commented
Dec 3, 2024
| import ( | ||
| "bytes" | ||
| "testing" | ||
| // func TestRedact(t *testing.T) { |
There was a problem hiding this comment.
Currently everything gets stored in the schema, so we're not redacting anything.
alecthomas
force-pushed
the
aat/schema-module-events
branch
from
7089658 to
6199a1a
Compare
This pattern allows us to update the runtime metadata for a module through the SchemaService.
alecthomas
force-pushed
the
aat/schema-module-events
branch
from
6199a1a to
394d485
Compare
alecthomas
requested review from
worstell and
wesbillman
and removed request for
a team
alecthomas
added a commit
that referenced
this pull request
Dec 4, 2024
This pattern allows us to update the runtime metadata for a module through the SchemaService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern allows us to update the runtime metadata for a module through the SchemaService.