feat: peer to peer routing #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2024
Open
Open
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
4 times, most recently
from
1c0a7b4 to
f367d7c
Compare
stuartwdouglas
added
the
run-all
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
2 times, most recently
from
b456380 to
b33868c
Compare
stuartwdouglas
requested review from
wesbillman
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
8 times, most recently
from
6f6a00e to
a688d4b
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
4 times, most recently
from
fedc798 to
d9c4c2f
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
from
18c2c40 to
975e6db
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
6 times, most recently
from
361a8fd to
a8c93e4
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
from
c7c9bb8 to
78fe647
Compare
alecthomas
reviewed
Dec 5, 2024
alecthomas
approved these changes
Dec 5, 2024
| @@ -46,7 +43,7 @@ func (c cronJob) String() string { | |||
| } | |||
|
|
|||
| // Start the cron service. Blocks until the context is cancelled. | |||
| func Start(ctx context.Context, eventSource schemaeventsource.EventSource, verbClient CallClient) error { | |||
| func Start(ctx context.Context, eventSource schemaeventsource.EventSource, client routing.CallClient) error { | |||
There was a problem hiding this comment.
Mmm cron makes me think - we'll need to have Istio rules for which FTL services can access what...not just verbs.
There was a problem hiding this comment.
Ah yea, I already have that to allow the controller and provisioner to allow access. I will update it to allow ingress and cron for modules that need those services.
alecthomas
reviewed
Dec 5, 2024
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
2 times, most recently
from
966b746 to
bb63ba6
Compare
|
I am going to disable the rolling deployment part of the kube tests, I don't think there is any point in worrying about that until well after the refactor is done. |
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
2 times, most recently
from
6689d36 to
5e64208
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
from
5e64208 to
968d22b
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/peer-to-peer
branch
from
968d22b to
c5a38de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.