feat: replace subscriptions in schema with verb subscribe metadata #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
added
the
skip-proto-breaking
matt2e
force-pushed
the
matt2e/from-latest
branch
8 times, most recently
from
d23c5ce to
35a04fc
Compare
matt2e
requested review from
stuartwdouglas and
wesbillman
and removed request for
a team
matt2e
commented
Nov 27, 2024
| isDarkMode, | ||
| ), | ||
| ), | ||
| // ...(module.subscriptions || []).map((subscription: Subscription) => |
There was a problem hiding this comment.
@wesbillman This PR removes Subscriptions as a standalone concept in the schema. And I'm not sure how we want that to affect the console... I've just removed the broken parts for now.
matt2e
force-pushed
the
matt2e/from-latest
branch
from
4539fcf to
b183f2a
Compare
stuartwdouglas
approved these changes
Nov 27, 2024
bradleydwyer
added a commit
that referenced
this pull request
Nov 27, 2024
* main: fix: race with concurrent deployments (#3553) chore: normalise Go binary builds (#3552) fix: move redpanda console off common port (#3551) fix: remove new subscriptions usage in console (#3550) feat: replace subscriptions in schema with verb subscribe metadata (#3528) fix: reduce the graph chaos (#3548)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscriptions are now defined on a verb. Schema no longer lists subscriptions.
go:
//ftl:subscribe <topic> from=(beginning|latest) (deadletter)?java and kotlin:
Other changes: