Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: db runtime as resource output #3523

Merged
merged 3 commits into from
Nov 26, 2024
Merged

feat: db runtime as resource output #3523

merged 3 commits into from
Nov 26, 2024

Conversation

jvmakine
Copy link
Contributor

@jvmakine jvmakine commented Nov 26, 2024 •
edited
Loading

  • Uses DatabaseRuntime directly as Resource output in provisioning
  • Separate Read and Write connector in the runtime
  • Extract logic under internal/infra to convert the runtime connector to a DSN

@jvmakine jvmakine requested review from a team and alecthomas as code owners November 26, 2024 04:25
@jvmakine jvmakine requested review from wesbillman and removed request for a team November 26, 2024 04:25
@github-actions github-actions bot changed the title db runtime as resource output feat: db runtime as resource output Nov 26, 2024
@ftl-robot ftl-robot mentioned this pull request Nov 26, 2024
Open
@jvmakine jvmakine added the skip-proto-breaking PRs with this label will skip the breaking proto check label Nov 26, 2024
@jvmakine jvmakine force-pushed the juho/db-runtime-as-resource-output branch 2 times, most recently from a800ce4 to 9ae4ee5 Compare November 26, 2024 05:04
@jvmakine jvmakine force-pushed the juho/db-runtime-as-resource-output branch from 9ae4ee5 to a7237f8 Compare November 26, 2024 05:14
@jvmakine jvmakine merged commit deb9b75 into main Nov 26, 2024
93 checks passed
@jvmakine jvmakine deleted the juho/db-runtime-as-resource-output branch November 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@wesbillman wesbillman Awaiting requested review from wesbillman wesbillman was automatically assigned from TBD54566975/ftl-frontend-team

Assignees
No one assigned
Labels
skip-proto-breaking PRs with this label will skip the breaking proto check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvmakine