fix: smoke test the tagged release before upgrading #3276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/smoketest.yml
Outdated
| cp ./tmpsmoketest/deployment/Justfile ./deployment/Justfile | ||
| echo "Removing tmpsmoketest" | ||
| rm -r ./tmpsmoketest | ||
| # # # These are disabled until the tagged release has the integration test changes. |
There was a problem hiding this comment.
is this commented out because you plan on bringing it back?
There was a problem hiding this comment.
Yeah it was, until we had a tagged release with the smoketest changes. Going in a different direction now though 🙃
jonathanj-square
approved these changes
Oct 31, 2024
safeer
changed the title
safeer
force-pushed
the
saf/smoketest_disable_noop
branch
from
b8ec637 to
23f46a6
Compare
safeer
added
the
run-all
stuartwdouglas
approved these changes
Oct 31, 2024
safeer
force-pushed
the
saf/smoketest_disable_noop
branch
2 times, most recently
from
1f53529 to
fb40a87
Compare
stuartwdouglas
force-pushed
the
saf/smoketest_disable_noop
branch
from
fb40a87 to
d27e329
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run the tagged release's smoke test on its released image, which sets up the deployments to upgrade, before running the upgrade tests.