Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build errors indicate if they are compiler errors #3197

Merged
merged 4 commits into from
Oct 28, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Oct 28, 2024

This used to be done with a special error struct, but that breaks as we move to language plugins communicating over gRPC.
Changes:

  • Build errors now have a type (compiler or FTL)
  • Position is now optional (to discern between actual positions and 0:0)
  • Go compiles without using RunBuffered() as that logs errors directly. This caused LSP to pop up alerts as it didn't know if was a compiler error.

@matt2e matt2e requested review from a team and alecthomas as code owners October 28, 2024 00:00
@matt2e matt2e requested review from a team and deniseli and removed request for a team October 28, 2024 00:00
@ftl-robot ftl-robot mentioned this pull request Oct 28, 2024
@matt2e matt2e force-pushed the matt2e/builderrs-compiler branch from 5aa360e to 4dd5e23 Compare October 28, 2024 02:22
@matt2e matt2e merged commit 2bb7dd7 into main Oct 28, 2024
91 checks passed
@matt2e matt2e deleted the matt2e/builderrs-compiler branch October 28, 2024 03:44
@matt2e matt2e mentioned this pull request Oct 28, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants