feat: update Attribute badge styling #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
force-pushed
the
improve-attribute-badge-styling
branch
2 times, most recently
from
8d4b538 to
a6c7558
Compare
deniseli
approved these changes
Oct 23, 2024
| <span className='text-gray-900 dark:text-gray-100 font-medium'>{value}</span> | ||
| </span> | ||
| <div className='inline-flex rounded-md text-xs font-medium' {...props}> | ||
| <span className='px-2 py-1 text-gray-400 bg-gray-100 border border-gray-200 dark:border-gray-600 rounded-s-md dark:bg-gray-700 dark:text-gray-400'> |
There was a problem hiding this comment.
looks like dark:text-gray-400 is redundant?
wesbillman
force-pushed
the
improve-attribute-badge-styling
branch
from
a6c7558 to
1f906c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes to make
AttributeBadgelook less bad :)