Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: buildengine publishes clearer state events #3168

Merged
merged 8 commits into from
Oct 22, 2024
Merged

refactor: buildengine publishes clearer state events #3168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f2c9f6
refactor: buildengine publishes clearer state events
matt2e Oct 22, 2024
dbcf845
chore(autofmt): Automated formatting
github-actions[bot] Oct 22, 2024
47a5c2d
lint
matt2e Oct 22, 2024
55f0cae
lint
matt2e Oct 22, 2024
43ea7a1
rename and make raw event not a type of engine event
matt2e Oct 22, 2024
60cb21f
rename func
matt2e Oct 22, 2024
95f6724
remove more code
matt2e Oct 22, 2024
85f3bbf
remove remaining terminal usage in engine
matt2e Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion frontend/cli/cmd_dev.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func (d *devCmd) Run(ctx context.Context, k *kong.Kong, projConfig projectconfig
opts := []buildengine.Option{buildengine.Parallelism(d.Build.Parallelism), buildengine.BuildEnv(d.Build.BuildEnv), buildengine.WithDevMode(true), buildengine.WithStartTime(startTime)}
if d.Lsp {
d.languageServer = lsp.NewServer(ctx)
opts = append(opts, buildengine.WithListener(d.languageServer))
ctx = log.ContextWithLogger(ctx, log.FromContext(ctx).AddSink(lsp.NewLogSink(d.languageServer)))
g.Go(func() error {
return d.languageServer.Run()
Expand All @@ -106,6 +105,9 @@ func (d *devCmd) Run(ctx context.Context, k *kong.Kong, projConfig projectconfig
if err != nil {
return err
}
if d.languageServer != nil {
d.languageServer.Subscribe(ctx, engine.EngineUpdates)
}
return engine.Dev(ctx, d.Watch)
})

Expand Down
Loading