Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugin improvements (stub generation, clean up) #3136

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: plugin improvements (stub generation, clean up) #3136

merged 1 commit into from
Oct 17, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Oct 16, 2024 •
edited
Loading

  • Moved stub generation to language plugins (ie: the stubs in the shared dir: .ftl/go/modules/...)
  • Renamed some proto fields. dir when talking about the specific directory to do work in, xyz_root when talking about a root of a larger directory structure, like project_root and stubs_root
  • Added some more comments to the proto

@matt2e matt2e added the skip-proto-breaking PRs with this label will skip the breaking proto check label Oct 16, 2024
@ftl-robot ftl-robot mentioned this pull request Oct 16, 2024
Open
@matt2e matt2e force-pushed the matt2e/plugin-stubs branch 2 times, most recently from fe7cb83 to 8f54fa9 Compare October 16, 2024 23:53
@matt2e matt2e marked this pull request as ready for review October 16, 2024 23:54
@matt2e matt2e requested review from a team and alecthomas as code owners October 16, 2024 23:54
@matt2e matt2e requested review from a team and wesbillman and removed request for a team October 16, 2024 23:54
@matt2e matt2e mentioned this pull request Oct 16, 2024
Closed
38 tasks
@matt2e matt2e force-pushed the matt2e/plugin-stubs branch 2 times, most recently from b9bc9f8 to c9e5b06 Compare October 17, 2024 21:27
@matt2e matt2e enabled auto-merge (squash) October 17, 2024 21:35
@matt2e matt2e force-pushed the matt2e/plugin-stubs branch from c9e5b06 to bf109e7 Compare October 17, 2024 21:36
@matt2e matt2e merged commit 68db03c into main Oct 17, 2024
96 checks passed
@matt2e matt2e deleted the matt2e/plugin-stubs branch October 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@wesbillman wesbillman Awaiting requested review from wesbillman wesbillman was automatically assigned from TBD54566975/ftl-frontend-team

Assignees
No one assigned
Labels
skip-proto-breaking PRs with this label will skip the breaking proto check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matt2e