feat: add proto for language plugin service #3060
Conversation
matt2e
requested review from
a team and
wesbillman
and removed request for
a team
|
@stuartwdouglas a review would be helpful having had the experience of adding jvm support. Would this protocol work well for building an external jvm plugin? (not yet aimed at live reloads) |
matt2e
added
the
skip-proto-breaking
|
|
||
| // LanguageConfig contains any metadata specific to a specific language. | ||
| // These are stored in the ftl.toml file under the same key as the language (eg: "go", "java") | ||
| google.protobuf.Struct language_config = 7; |
There was a problem hiding this comment.
Should we make this strongly typed using google.protobuf.Any? We'd likely need some mechanism to pass the descriptor to FTL from the language plugin so it knows what to expect, so I'm not sure it's worth the hassle.
There was a problem hiding this comment.
Yeh I tried with google.protobuf.Any but we needed the proto definition for each language config, which was why I backtracked to just a generic struct. I didn't think it would be worth the effort for now.
| // FTL may ignore this event if it does not match FTL's current build context and state. | ||
| // If the plugin decides to cancel the build because another build started, no failure or cancellation event needs | ||
| // to be sent. | ||
| message AutoRebuildStarted { |
There was a problem hiding this comment.
I was thinking that it might be good to have a sequence diagram in the design doc for these flows, WDYT?
| // Each time this call is made, the Build call must send back a corresponding BuildSuccess or BuildFailure | ||
| // event with the updated build context id with "is_automatic_rebuild" as false. | ||
| rpc BuildContextUpdated(BuildContextUpdatedRequest) returns (BuildContextUpdatedResponse); | ||
| } |
matt2e
force-pushed
the
matt2e/language-proto
branch
from
6e855b6 to
4bd40de
Compare
matt2e
force-pushed
the
matt2e/language-proto
branch
from
4bd40de to
eb8cae7
Compare
No description provided.