Language plugins #2785
Closed
Language plugins #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Justfile # frontend/cli/cmd_box.go # frontend/cli/cmd_box_run.go # frontend/cli/cmd_build.go # frontend/cli/cmd_deploy.go # frontend/cli/cmd_dev.go # frontend/cli/cmd_serve.go # go-runtime/compile/build.go # internal/bind/bind_allocator.go # internal/buildengine/build.go # internal/buildengine/build_go.go # internal/buildengine/engine.go
Open
alecthomas
reviewed
Sep 23, 2024
| shopt -s extglob | ||
|
|
||
| if [ "${FTL_DEBUG:-}" = "true" ]; then | ||
| go build -o "{{RELEASE}}/ftl-language-go" -tags release -gcflags=all="-N -l" -ldflags "-X github.com/TBD54566975/ftl.Version={{VERSION}} -X github.com/TBD54566975/ftl.Timestamp={{TIMESTAMP}}" "./go-runtime/plugin" |
There was a problem hiding this comment.
Let's name go-runtime/plugin -> go-runtime/cmd/ftl-language-go so it's more idiomatic.
Comment on lines
+25
to
+33
| message Pair { | ||
| string key = 1; | ||
| string value = 2; | ||
| } | ||
| // Universal metadata | ||
| string name = 1; | ||
|
|
||
| // Language metadata contains any metadata specific to a specific language. | ||
| repeated Pair LanguageMetadata = 2; |
There was a problem hiding this comment.
I'm not sure what's going into this or where it's ending up, but we should probably be using google.protobuf.Any instead of a bag of values.
👍 will do. I think this PR will need to be split up more regardless... it's pretty hairy atm |
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very early (and messy) WIP...