feat: completion for interactive mode #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
jonathanj-square
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/2708
branch
from
33a9740 to
4596f9b
Compare
alecthomas
approved these changes
Sep 19, 2024
frontend/cli/cmd_interactive.go
Outdated
| type interactiveCmd struct { | ||
| } | ||
|
|
||
| func (i *interactiveCmd) Run(ctx context.Context, k *kong.Kong, projectConfig projectconfig.Config) error { | ||
| type FTLCompletion struct { |
There was a problem hiding this comment.
I know I said to put all the types at the top, but I'm going to slightly contradict myself 😂
It's preferable to have type followed immediately by methods. So in this case I'd put FTLCompletion + methods at the top, then interactiveCmd + methods below that, so it still works to read down the file and have seen everything.
Not a big deal though, but just for your reference.
There was a problem hiding this comment.
That is where I was going to put it, but I remembered your comment from yesterday :-) I will move it.
| lastCompleted := "" | ||
| lastSpace := false | ||
| // We don't care about anything past pos | ||
| // this completer can't handle completing in the middle of things |
There was a problem hiding this comment.
Yeah I've noticed that before, it sucks a bit :( - still, better than no completion
| @@ -62,3 +74,72 @@ func (i *interactiveCmd) Run(ctx context.Context, k *kong.Kong, projectConfig pr | |||
| func errorf(format string, args ...any) { | |||
| fmt.Printf("\033[31m%s\033[0m\n", fmt.Sprintf(format, args...)) | |||
| } | |||
|
|
|||
| func (f *FTLCompletion) Do(line []rune, pos int) ([][]rune, int) { | |||
stuartwdouglas
force-pushed
the
stuartwdouglas/2708
branch
from
4596f9b to
3510a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2708