Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: console background color scroll bug #2709

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: console background color scroll bug #2709

merged 1 commit into from
Sep 17, 2024

Conversation

deniseli
Copy link
Contributor

Fixes #2698

There were actually two underlying issues fixed here:

  1. If you hard scroll down on any page in dark mode, the <body> element would not respect dark mode, so you could still see white bg underneath. That's gross. It's fixed now in index.html.
  2. On the infrastructure page specifically, we never set the page body's overflow behavior to scroll, so instead it would overflow the container. Technically, with 1 fixed, you wouldn't even notice this issue, but it was still worth fixing to future-proof the page.

@deniseli deniseli marked this pull request as ready for review September 17, 2024 20:05
@deniseli deniseli requested review from a team and jonathanj-square and removed request for a team September 17, 2024 20:05
This was referenced Sep 17, 2024
Open
Open
@deniseli deniseli enabled auto-merge (squash) September 17, 2024 20:08
@deniseli deniseli merged commit c19246a into main Sep 17, 2024
93 checks passed
@deniseli deniseli deleted the dli/bg-bug branch September 17, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas

@jonathanj-square jonathanj-square Awaiting requested review from jonathanj-square

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console content overflow doesn't maintain dark mode
2 participants
@deniseli @wesbillman