feat: service based load balancing #2702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
added
the
run-all
stuartwdouglas
requested review from
a team and
worstell
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/service-based-load-balancing
branch
2 times, most recently
from
717e7bd to
504c216
Compare
stuartwdouglas
added
the
skip-proto-breaking
stuartwdouglas
force-pushed
the
stuartwdouglas/service-based-load-balancing
branch
2 times, most recently
from
526a9f4 to
2bff534
Compare
alecthomas
approved these changes
Sep 17, 2024
|
Awesome! |
stuartwdouglas
force-pushed
the
stuartwdouglas/service-based-load-balancing
branch
from
2bff534 to
dc563ab
Compare
stuartwdouglas
deleted the
stuartwdouglas/service-based-load-balancing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still maintains the existing route table, it's just that every entry now points to the kube service.
If we are going to completely re-vamp route tables I think it is better to do it as part of a larger commit that also adds rolling deployments, but I will leave that decision up to @alecthomas