Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JVM Map value type extraction #2658

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: JVM Map value type extraction #2658

merged 1 commit into from
Sep 18, 2024

Conversation

tomdaffurn
Copy link
Contributor

Closes #2651

@tomdaffurn tomdaffurn requested review from a team and safeer and removed request for a team September 12, 2024 05:43
This was referenced Sep 12, 2024
@tomdaffurn tomdaffurn added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@tomdaffurn tomdaffurn added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
Copy link
Contributor

@jonathanj-square jonathanj-square left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so close, off by 1!

@tomdaffurn tomdaffurn merged commit b805ee8 into main Sep 18, 2024
90 checks passed
@tomdaffurn tomdaffurn deleted the tom/map-types branch September 18, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect schema for JVM verb with map parameter
3 participants