-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish jvm artifacts #2640
Conversation
Co-Authored-By: Tom Daffurn <[email protected]>
9e80318
to
1d94655
Compare
1d94655
to
ea9f669
Compare
SummaryThis PR introduces the changes needed to publish all jvm artifacts to maven central as part of the pre-existing release github workflow Note this is the first of a few PRs to set up jvm artifact publishing with all bells & whistles JVM Artifacts
Changes
ConsiderationsMove jvm artifact publishing into a separate github workflowbenefits of this would be the ability to publish artifacts independent of releases. this can be helpful in scenarios where:
We could set it up such that successful completion of the release workflow triggers a Mirror artifacts and third party deps in artifactoryOther JVM artifacts published at TBD do this today for redundancy, availability, and caching |
Was the Java doc not needed @mistermoe? I was getting errors from Sonatype without it. |
Oh really? We should add it back in then. I only built the artifacts locally which worked fine. Didn't try re-publishing. I removed bc we aren't using dokka anywhere afaict |
jvm-runtime/ftl-runtime/pom.xml
Outdated
</plugins> | ||
</pluginManagement> | ||
<plugins> | ||
<!-- generates a JAR file containing the source code of the project --> | ||
<plugin> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want these in the plugins section, they should be in a profile, e.g. there is not need to generate source artifacts in a development build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point, I added release profile to group signing and source jarring
jvm-runtime/ftl-runtime/pom.xml
Outdated
|
||
<!-- specifies where the project artifacts should be distributed or deployed. | ||
tells Maven where to deploy your project's artifacts when you run mvn deploy --> | ||
<distributionManagement> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the .settings.xml? I also don't understand what the use case is here, won't the TBD artifactory pull them down from central once they have been released?
jvm-runtime/ftl-runtime/pom.xml
Outdated
</distributionManagement> | ||
|
||
<!-- additional repositories that we can pull dependencies from --> | ||
<repositories> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is a bad idea to put TBH repos into a publicly published pom. This will mean that projects consuming this pom will end up with these repositories in their repo list. If we really need them they should be in a
settings.xml
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartwdouglas it may be best to connect with @ALRubinger as he paved the way here for other jvm artifacts at tbd. Take a look at web5-kt or tbdex-kt for reference.
No real opinions from my pov especially with limited jvm experience. Happy to do whatever you think makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved it to a settings.xml profile for now.
Closes #2636