Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use div instead of DisclosureButton for decls in the module tree #2587

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

deniseli
Copy link
Contributor

@deniseli deniseli commented Sep 3, 2024

This fixes a Cannot read properties of undefined (reading 'length') error that was appearing every time you went to the modules page, which was coming from inside DisclosureButton. The error's stack trace was minified beyond comprehension, but I'm guessing it was because this was a malformed usage of DisclosureButton - not wrapped in a corresponding Disclosure (its parent Disclosure component mapped to the higher level module buttons, not the decl items).

@deniseli deniseli marked this pull request as ready for review September 3, 2024 20:40
@deniseli deniseli requested a review from alecthomas as a code owner September 3, 2024 20:40
@deniseli deniseli requested review from a team and gak and removed request for a team September 3, 2024 20:40
This was referenced Sep 3, 2024
@deniseli deniseli requested a review from wesbillman September 3, 2024 20:41
@deniseli deniseli added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@@ -65,4 +65,4 @@
</body>
</html>
<script>
window.playwrightReportBase64 = "data:application/zip;base64,UEsDBBQAAAgIAOiCI1nO8g0y7gMAAJgcAAAZAAAANDJiNjc3ZWJhNTY0YTkwZGJiMTguanNvbtWYz2+jOBTH/5XIp10pdf0LbHObHWk0e1ntoadd9WDANEwJjsBMO6r6v69MIk36lgSCSNW5oQR/3/s+288f/IKKsrJ/5ihBgqWxlDY1USyMJnmaUoXW/f9/ma1FCbLfbe1b3O5shn2L1sjb1rco+felfzqpcqMLbotcpqnkJhOZUIaRMLz0VdDNbWG6yrcr71Z+Y1f7OKudebBojXaN+2Yzf8gh2zRuW3ZbtEaVy4wvXY2Slz7LoQyrsrYo4WuUuarb1iihr2uUd81hoCAiWiNT1873vwQz92vkzcPhyXU+c3vzzzubeZuHjIzf7P9ubBsS70sAVVtvGn9X9oMZYeKG6BvC7xhJGE+IxIrrf1CQ8M0PlJAwwO4O1TwU5g9buMauvjr3GMyMKgoeFI8SoUQM6Rbls+8am6zSxj21tpmiHZG32kyrIemD4t2PncWV6epsM0mcQfH4p/h9mL2u9mHyjp/XA4YyV3v77EdjKkyFfhuTRmf84No+fZ6uDf1QMs/OYQuMxosjUD9ybnIORoKnv6cGkDDAzAma6IhLsJR5JPmQpaCHH5x3v2283yW3t6ErVBvX+kQpzW63Lu8q2/4+KSYwGVHxxuRAwyl8dRN633G3UUfdJn4drkef9pMp/RfXfOnqrJcdT1FpWBYS8Tk56lM5Tpc4aqqMvY4vgZGZGp0hSrEWCuyr8Rk6cSSIowKIE5O0b/nYu6/mu/1cmXa0CVOGCdyLlOiZOcqfOXJ6IsdPhbfNtBOCMkylAMnJs+fDlN3aywLPZM6aPLmg5vaR8cyWOEsuiAKebdO45vBO643v2n6btG1PGcZ7k222YWWEV8IA94gS33S2T/cscWWp1ZRwaoosJjZnaaqimcRVlI0t3PMywMVjxZcHrr3qKGUwtjRwMQGBi8dnN9QFwMVAr9P8HKBcCFycQHE+7zyfDlwyhmeXGKzVLOKSsOtyMdPQJEDRmFJQQc70GTeXItdYgCs4EhwAMYsYvSpyaSwEMBnHas7RcS3kogRTAplDRXROjr8ocsUUtDg+CpzvjVxcx7ANfxjiEhx8VAx+mF2KNf9T/TDAJbh6B+CaGuX9gCu3WpAsljSVPM8UV4KmM4HryaaPpV+GtyiN4uV5a696fpI4ZnsqXoq3ekXYiwllS/BW0FYc9vnBu7PLeasXh99d6rq8RTkWMSjWWUC5ALd6bcgKV7wOCvE09DLM2fNoqw8ADR3T9hUcSQ5WRBQNOloKtvqQkJHl6M3Eu8KWwJTCyxMZzUnxV2QtgZkGNEz1XJC5EmsJLBS82mZyZo5Lw5bAMfxmGr7Tv2yvDsh+ENoazWyRkyREEe9LW/ev/wFQSwMEFAAACAgA6IIjWeNlK+1kBAAAPSQAABkAAABhNTU3MWZiMzcyYzBjOTFiNmU4Yi5qc29u7VlNb+M2EP0rBi/ZBRyGnxKlW1NgsQsURbHI9tAiB1qmY9WyaEhUnSDIfy/IGI3NlS3ZpjYG2ptgWW/eDMmZ96RnMMsL9WUKUiA5j/FsQmOSoSzBk0iJCRi7+7/KpQIpyMtZJWtTNZlpKgXrlcqgqcEYGFWbGqR/PrurvWjXWKpJTBGTTKBoMmUki4R9PDeFxa/nel2PdqOAMVhV+i+VmQ2JbF7pZd4swRgUOpMm1yVInx3NQxSLvFQgpWOQ6aJZliDFL2MwbaoNAE0oHQNZltq4X2w292Ng5MPmSjcm046AelypzKipZSbN/PV2peqm2NTAR62NrMxd7h4miLBrlFwjekdQSmiKYigo+wNYCFM9gRTZB9RqU85NZW7VTFdq9FnrhU2mGzGyiG9EGMa8DXeWP9o6paNJpde1qvpgM7yLTXEr5Q3i3dNKwUI2ZTbvBU49cCTewO/t6jWlsYu3fT1uSSjTpVGPpjOmgJiT3ZiYHMgHlmr98xHYzMNGp6Wzkg+qT7yIe/Gi5EAym0RsTr+FCDBARpR6AWmEo7aULB580EZ/mBuzSm9ubHco5ro2qRAJuVnqaVOo+mOfmMyLyenusrU0npkprm3z2+42YqvbRC/t9XC01zI3n3T1qSkzB9tNUcSRf1BifgrHZB/H/hBbTZWQl+4t4GB1BR+UuX36qgv14arIy8XVePQ8KuVSpaOrLztt/Gr08hFmRZ4tuiqDMUy4VxkRd9WlY2jwt/wo3rOMr0MBGv1Z/q2+ff2lkyiByN9l4kye0b51aON5q37P63xSdJ5By9TvYtGZTLc2HQ3LNELe4DuTqZ0F/xZVhKXqFZWeS5UPV9XY64fnUt3qjCTeQ/WnmVFVP8ljOca9pvhR48fBeoIEn9Jk93bIUwejY+btnz3K4gxxdEQU71pVla42/6mNNE3tRl1dO9ksjZHZfKlKJ5jv7QN6AVJTNcrRPegh4iSTVGEl2ZSQSTKbckmP9RCzvFIz/RjWQuAkweEtxCtq1zKxBIW0EA7RO0+EsSAWwmF7I5rzQBbCgfvNip2oUPueEgoRi31PFMZCOGzhLcSJjqhXX6EQxV68CB1K5kgL4QIkfoABTRGmMBLIHw08bksplIVwMbEf87I8BGYwwf4R/99BuLpQf4N2Dv33cBAcIkTD6vKBHIRl6pf0Mh0Ehwj7s+lCHQSHiODAVAdyEJaq/0Ly0hwEh4h6Y6J1Rhw3fCwqPiSg381AdDILIo36R/lxBmI6zaQQUmQsQRgzoeREHWsg1mqyyE1Y/xDxAb5AONCugReRJKh7YDDyzxKP2MHT1HdDWWhvQwV6W98BHVyX2nD+xwF6yAYdq7S7AgyQUex/HWCk9fNDMKHdEpJickqHHUxnc4hizx1i3Cl//gNCm0OceGsXdw7H9xHaJAosCgcT2iQOrAkHE9rEPxWdx/bdhDbx31icTXUwoU2E/xr88oQ2EbTHBD9Wzn6HejFCu4NZIKHdN0owoX3/8g9QSwMEFAAACAgA6IIjWXYMNbCmBAAAJiMAABkAAABhYWUwZGIxOTRmMGRhNTgxYzU0Zi5qc29u5Zlfb6s2GMa/SuSbtBJ1bWOMzd066ehM2qbpqNvFpl6AYxpWgiMwp62qfvfJBOmknlMIJVW3cxcl8Lzv4z/v+7PzBPKiVD+tQALSVKFVhgXN0SqNOJYRzUHQ/f5rulEgARu9aksFm62S0DQgAEY1pgHJX0/dp4MqF1nMpExFqLIYs1VGM0KIfb0wpdVt1vq+WXxVddYscl0vVmpb6seNqgwIwLbWfytp+hTkutabot2AAJRapqbQFUieuiR9CZZFpUASBkDqst1UIMHPAVi1df9izKMwAGlVadN9Y73cBMCkt/0n3Rqpu8DqYaukUSubUWrWu59r1bRlPwKuamPS2lwX3csEEXqBxAUKrwlKSJigGPIw/BNYCVM/ggTZF9S2H8x+XK5Urmu1+Kz1nTUzrBhbxW+JUIwjn25ePJi2Vskiq/V9o+ox2jR8qR0i5pPuFa8ftwqWaVvJ9Shx4YrvjceNnb22Mnby9j8HHkNSV0Y9mMGYHOIIvYzpH6reD6zU/Y9HaGNHe6KdbXqrxsRjkRMv9q6n3kxvxHr6bWwA5gRg4qSOwtBxFDIc+yxZPXirjT5bG7NNLi9tVSjXujEJ54Jc7ipCcz4mJnVWRBTFL0x6Ck5uygtb+varDd+rNuzZPx5d2vdpYT7p+lNbyU52OEUuuLtRdqXm2BzFoRzHS+wVVUKeh5dAJ6treKvM1eMXXaqzZVlUd8tg8bSo0o1KFstfdpO1XDyfQ1kW8m5oSDCGInKKHhdDA3KgS0R7huiBefOYyFpjdLVvQ8m17jz0T58tm6+3y3NYmfUZHuuMQORWqAhPdLY32wQdcLbrb9Doz+lX9fuXn0ckiJHTEzCdmCDGhxaTL8Mr9UfRFFk5WEhsjthpLdHUFPfWOwtnTZFQZ1NzNlh4DmVJv2UZHcryh9yoehxV4AgKQZwN9ipSjCnwPlU0pYwdrEFTW48vM+zvdG/Ajy5K+Jp/bzG9CYCqa133zzQmNW3TNZOm6cA0NSaVa8vN3SP2BX0HElO3qkv3dUaXcR4TJXFIZBiilCqRTWP0vKhVrh/mQXQsaDw/ou9Uh3Ym5WJORLeK7uIiIfJyzbGI3mk7zBQx7JM+HtE7ceaKnxbRcQhRxNzBmgfRO20HG8iBbT4H0Np4sdOH2H6zfCuiDwY4gSMmnLaFMfIeoeZC9C5m7B6sGJ/SOE7F6JjC2D0rheR7JnQKuYuJ0f+D0CnkzNkCbHCq35PQKRTE3S9TEzwVoVMo3GM3nXyKOBGiUyi4e8EyiKvvBegUCrfvzwDoVpV9SEAfzGwW+Bgf5f0AfaVErLjAOCNSSCJWnOBpgH6vsrvCzMPnHLP58bwTHTpCxWLWC/RO0b1LIuLVvTQWziPIkUtL7LUr2mPgPIIcu+WJTryePeIA6945zwbnPm0yzc7YIz932Jkg77xPhHN72kduAH5CRwxi96KYEm9XmI3NGSTI9cgHG/m7ojmDlLubkH7XbM4gI+71KBsakP8EmzPIeDyTs5OwOYMxdRbj1FPRqdCcwTj6V9P6YGjOYBw7/7UO/h/2XmRuc3PPh28nc4/qByFzm1l0cjIfH2U2Mr95/gdQSwMEFAAACAgA6IIjWSD3w/lcBAAAhyAAABkAAABjMzBjZDM5ZTFjODdmOWZmNjU2YS5qc29u3ZnLbuM2FIZfxeAmM4DD8CJSpHZNgcEUaItikHbRIgtZomLVsmhI1DhBkHcvqAgYh5ZNWZU9wewE2/rPf3g55yP9DLK8UL+kIAIJRUlKpcKJCDOZZZzxGMzb73+P1wpEYK3TplA1rDcqgaYGc2BUbWoQ/fPcPh2UuVaKU4JDHMQoQ2m8YIQq+3puCitcL/W2nsWJyb+qWRcFzMGm0v+qxHTRk2Wl13mzBnNQ6CQ2uS5B9Nz66/VW5KUCEZ2DRBfNugQRfpmDtKm6N6mkZA7istSm/cSmcT8HJn7onnRjEt1GVo8blRiVWkuxWb5+Xam6KbrkXdXaxJW5y9uXCSLBNZLXiN4RFBEaoRAKyv4GVsJUTyBC9gW16caxG5JblelKzT5rvbLJ+BWlVfxmJMBI9Olm+aNpKhXNFpXe1qoaoh042kT2SneKd08bBYu4KZPlEHFGXHH2Tfzezl5TGjt5u8/znoQSXRr1aLwxBcSBeBsTB0fygaXa/jxcmyFHG41LZxM/qCHxOHXi8WOT0yVic/pjaIDADRCeNSNK8duAlGPel5LVgw/a6A9LYzbRzY0tC8VS1yYSQpKbriR8HBIzcGaNsbersKfiZKa4tlVvt9qInWrDX/rHo7W9jXPzSVefmjJpZf0WhQydYUEMjfEoD3kcLrFTVAl58S+BVlZX8EGZ26cvulAfroq8XF3NZ8+zMl6raHb12+tkXc1ePsKkyJOVb0gwhpI5K0US34AcahNsJ6PgwMS9tgFo9Of4q/rzy69ehwSigDmbZ7RDfmjM+xzeqr/yOl8U3v1mPTJnYQVjLe6s/sA7iCdZ5E6ToGMtygEWf8qMqoZ13tabO8X4aN8dUgV7Zcfs9YMbdWx9bp3xt84ONLj/0aPbKOGgKM6zqipddb+pTWyauq24dd3SW2xMnCzXqmy57d6+oFcgMlWjWrtHGZYmFMmUKU4FoimigoTBqQyb5ZXK9ONECEuQRNMj7Kuqb34YC6ZE2FbRWVeECXJ0Kw1E2FbbQVjGey2fjrBWnO/BgzwrwmIKMXaZ/Fg+JyCs1SYuwopx6QwqKBRi9+xygPfGIaw3wBkyCplbvKmgfSlNhbBtzNCNyfmYnnEuhsUMYuKeJbys8SMTLNtfmVT4BuSiBMsgDp2zsvdcdGGAZRALZ1WNHsMzASyDWDoAK8danBpgGSTIOUWFR5vuoBJoVckxfvtu/Op1NkmDHh7lcvwa4lSoAKssDlCqQo6lXJzKr1u1WOVmInwNAzw9vbaivskRjE4KrwwK7mwigXrvFE9mVyvN3cbeyxIj2NWK71EDGYdGw7eGlG7T6z0xj2BXDpG77cg5SY9DRF1WPno3fiq72gDYDXDG61fMISHuPwn0rLevNqQ7iO5/AN+bXDlkZG8TeinjR0ZXDrlbOZj3huqi6Mph6J5jvcehC6Ortegsq/d298phuLc53wu6Wm/k4OFkfAUMKX2X6Op1Nkl/Hh5lMnS9f/kPUEsDBBQAAAgIAOiCI1m2YM2WSQUAAIIsAAAZAAAANDY1MjNlMTc0OGRlNTA0OWVkMjQuanNvbt2aX2+bSBTFv4rFS1rJmc5/Bt62q1ZdaXe1qrJ92FUeMB7HbDBjwdCkivLdqyHejXONDUyhSffNisO558BwuT/Gd8Eqy/UvyyAOuBSUaRJytdQC80gvKQ/mzfe/JxsdxMFnXS5QtdUpslUwD6yubBXEf981n45qnNOEL3ikEh4tNMbLpZIMu8MzmzvVam1uqpnTnq1MuQnmwbY0/+jU7qqm69Jsstp9kZs0sZkpgviu8XXoKc8KHcREzoPU5PWmCGJyPw+Wdbk7jmNO5kFSFMY2f3H+L+eBTa52n0xtU9PU1bdbnVq9dIYSu374utRVne9SQ9XKJqW9yJqDKab8HEfnmF1QHFMW4xApRv4KnIQtvwQxdgfo7e4E7s7FW70ypZ59MObapelWFE5xzwijvE130ei+S9L1bG3MdS9peSDN2qRX2a2tSx3PFqW5qXTZSzt6qs1w1Or6QfHiy1ajPKmLdN1HnFMoLh/FL93CqAvr1sX+53lLoNQUVt/azpoKEa6e1iTyRB5U6Juf+2sL9lRb+aXZJle6TznJQRTVulJ3WXY5XKQ/+hYAa5aE0aSJGAcFmcSkLZLTQ1fGmldra7fxmzeu3eRrU9lYqYi+2Zhlnevqda+aYEEILp6EbOlkK5ufu0a638jUXh+T9+3no7F9k2T2vSnf10XayHZbVJGE94nAPh6jYx77S7BHCUqPxGykTImutH375aPJ9auzPCuuz+azu1mRbHQ8O/vt4QKdze5fozTP0s4+RwiKOOhFgnWdhNZHjtiLwPtHWNTWmmI/hE7XZkACijCGCTqXWmuCvbVG8bcmmL273ZrS6uWwKLA3KO4VhZC9NamOZHl4viNrPiSf9Z8ff+3hjwhyqhf3tnd0vQ8Q2dOI7ru75n9p3+pPWZUt8s7W6fJKkNfzcoSPXkXY53J8SvK6n0HQxPyWPtlb++JYA/I7gyGcRrwMUjzkDA4zCJ+Ofgb37jh5rP95GlSjGKR7BtkRgz+trC77Td/OmQJ3R+sQO2hcaVTBivF6KPd5oo7sbIxZekAV8FmXpSl3/1PZxNZVMxpVVQNwibVJut7ookG3S3eAuQ5iW9a6sXuSXxPOOGGEa75ISUK4ShUdwK+rrNQrczsKvlLGw/Hx9UG168IIIcbE10YxfHqpqZJ0BHxtpNWBdOvQPxRfnTZ8Koqw3fVgfG3EAe4J6YlHfW85hggDNekp5BuAr432AU9OR3uungD1QipOhBnIr00BAQvwSROpEMz3hKnWSGPxq6sJH22Eyc5Z93sCLBGICgw8dk6n/zd8FYjCAZj7jejPha8CMQKWGvMb8J4dX8XhmyYReUWZBl8F4hi+evPkuR+DXwXiFLQISvwCTwSwAvGDt9UvCmCdQdBgSCePfFeCFYgLeRTDXgDBCsThWy1Pg2MTrEA8BMNS67bFsIGlRfWFEKxzJiYn2P5Vvh/BpjQJ01REqcaYiDSSDIcDCPZGL64zOwrAKqzG59dG9PRVkf++KhwNX50iGMwj2oqYQ+m1v/JgeJWIhAzOAKdgbwi8OnEIe2xieJWIEVCTjrT32miDO5kyvzi9+pNEjMN55eTG+FB4dQUILDAljksk4PYaC8NJ2VUiATdpqN++5mToKpHCEK+p1/bwj8yuEkUUvtn3Gy2fi10ligRc3dIrwbOzq0QR/DmACL2iTMOuIcLwtRvz3Or7Mdg1RDiCr7c8XyZMxK4hIvCHB9TP4ETsGiJCAFz70f9U6OoMwnnpRaGrMwgHoJeBrs4Z2Dtq/d3jsHGlRfWFoGuns1GG6ZYqpHs6/CZ0vbz/ClBLAwQUAAAICADogiNZfe1Mz28DAACgFAAACwAAAHJlcG9ydC5qc29u3ZfJjts4EIZfxeBZbnATF7/BXHIKMIdBH4rFUqyxbBkS1UnQ8LsPaDtJe1ptRUZi9IxPpCTX8lX9JeqZbSlBhARs9cwA0wDNn223oa5nK3MoWJ+gSx/rLbGVsLJUXntnnHQFi0MHqW53bCW44v5Ba+e//QpW1Q31bPXX83H1R2QrpmUw1lKA0mjwPIYgHDs9+QGyA0ZPtEv9Q78nfEg9K1iiPp2s5NWbVpa+UlRFG4JVgBq1A8nz3+vUZLuRKhia1C9Su0hrWpz8LPbwiVjB9l37N2E6x4Drrt3Ww5YVrGnxnOEpi7EIm3pHbKUKhm0zbDOMw0s0muuyYLDbtel4JSfzWLAEn86rdkjYnpL/sidMFHNEkNbn2xu2St1ABeuozykcYUBKgOttDiU/dng8FFOEMJAXXAmo0HCKMgRX3kioqjuq2i+/BpAyTr0LQJG85misCFZFdMppEW4E9JnCpk6/ho8QpbkHn8ej1PP2maU2QXOM6bvJvBl2P7a8YFUDm6/HVb+p9/vz1W/+Dpn4d+lDWVpRBWUlcvQiGHLhUvr1ruqgT92Aaejo+ggYs7YUQMEqrkE7bkLUEo17Ub9+3X7uF5deZmr/zRCnWtyru7f4KCLrERQJAh2lDL6KJai5iK6K/1ZCwnvxLgjFiOAcONSeC6EdQaC5hK6p/1ZAprxLB/3mIQDEYxBeVzxC6QSWurocAts2Ds2U+EesLIM1iOAVBStMDDpIKV/V7Ym60C+qtltE2jft15z5zBHwKsCJull3n8IVk4DQVlYSCiVRKQ6afLgN0NUBMJeP8Nq+Cz6RvCXnhQgSPUofnRS38bkm/7l4nPgfvPtRcYzKk0BnK19VpjQwJvuJc/+YmSWRUVJYoYHnaoZSqtfzGjDVT7Q4e7lJ8XMOtF7Je7f0KBuFivtYklGOq8iVk1bPZfMTYp+BRnLP3wUaK6IjLagCzSNZI/zINJxAM63zGWSsvsv55/cKXZssP2G1i1Ry7SlKfSn0PEAnvu5HbCwl6KC9A+0DcR6jM4qPDuc8m7czBf6vmE6FynP3zQ/6ux9VR6GAVloooUkHFCC0Qzd+5BmHclXZM5lIdf+3+CgTlGARS4/EuSjRG8XtDCbXJD0TiePuvynoxwso2c9L/fzomjOrkQBE+TKCvJsXQsGo69rulOI/UEsBAj8DFAAACAgA6IIjWc7yDTLuAwAAmBwAABkAAAAAAAAAAAAAALSBAAAAADQyYjY3N2ViYTU2NGE5MGRiYjE4Lmpzb25QSwECPwMUAAAICADogiNZ42Ur7WQEAAA9JAAAGQAAAAAAAAAAAAAAtIElBAAAYTU1NzFmYjM3MmMwYzkxYjZlOGIuanNvblBLAQI/AxQAAAgIAOiCI1l2DDWwpgQAACYjAAAZAAAAAAAAAAAAAAC0gcAIAABhYWUwZGIxOTRmMGRhNTgxYzU0Zi5qc29uUEsBAj8DFAAACAgA6IIjWSD3w/lcBAAAhyAAABkAAAAAAAAAAAAAALSBnQ0AAGMzMGNkMzllMWM4N2Y5ZmY2NTZhLmpzb25QSwECPwMUAAAICADogiNZtmDNlkkFAACCLAAAGQAAAAAAAAAAAAAAtIEwEgAANDY1MjNlMTc0OGRlNTA0OWVkMjQuanNvblBLAQI/AxQAAAgIAOiCI1l97UzPbwMAAKAUAAALAAAAAAAAAAAAAAC0gbAXAAByZXBvcnQuanNvblBLBQYAAAAABgAGAJwBAABIGwAAAAA=";</script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should be in the repo at all 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix in a follow on PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops x2, I accidentally pushed a fix for this before seeing your second comment. I'll slack you

@deniseli deniseli added this pull request to the merge queue Sep 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 3, 2024
@deniseli deniseli added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 2e489cc Sep 3, 2024
23 checks passed
@deniseli deniseli deleted the dli/js-bug branch September 3, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants