Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor JVM code #2467

Merged
merged 2 commits into from
Aug 22, 2024
Merged

chore: refactor JVM code #2467

merged 2 commits into from
Aug 22, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

This moves the dicovery code for various API constructs into their own classes, and makes the whole process more composable.

This moves the dicovery code for various API constructs into their own
classes, and makes the whole process more composable.
@stuartwdouglas stuartwdouglas requested review from a team and jvmakine and removed request for a team August 21, 2024 00:18
@ftl-robot ftl-robot mentioned this pull request Aug 21, 2024
@stuartwdouglas stuartwdouglas added the run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue label Aug 21, 2024
Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although I'm not an expert in this area :)

@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2024
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit b20986b Aug 22, 2024
74 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/jvm-refactor branch August 22, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants