Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add kotlin test #2395

Merged
merged 1 commit into from
Aug 16, 2024
Merged

chore: add kotlin test #2395

merged 1 commit into from
Aug 16, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

No description provided.

@stuartwdouglas stuartwdouglas requested review from a team and deniseli and removed request for a team August 15, 2024 23:15
@ftl-robot ftl-robot mentioned this pull request Aug 15, 2024
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/kotlin-tests branch 3 times, most recently from 1a6b96d to d835523 Compare August 15, 2024 23:17
func(t testing.TB, ic TestContext) {
root := filepath.Join(ic.workDir, module)
// TODO: Load the module configuration from the module itself and use that to determine the language-specific stuff.
if _, err := os.Stat(filepath.Join(root, "go.mod")); err == nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's factor out this and the other code that does this into a common function.

@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/kotlin-tests branch from d835523 to 1085858 Compare August 16, 2024 04:30
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 9f40854 Aug 16, 2024
17 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/kotlin-tests branch August 16, 2024 04:46
safeer pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants