Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add directive to enable lenient json #2377

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

worstell
Copy link
Contributor

@worstell worstell commented Aug 15, 2024

fixes #2132

adds support for ftl:encoding directive. the default ftl:encoding type is json and presently supports only the lenient option.

//ftl:encoding lenient or //ftl:encoding json lenient (which are equivalent) can annotate an ingress verb. when an ingress verb is annotated with this, it will accept requests with unknown/extra fields and ignore them.

@worstell worstell requested a review from alecthomas as a code owner August 15, 2024 03:21
@worstell worstell requested review from a team and matt2e and removed request for a team August 15, 2024 03:21
@ftl-robot ftl-robot mentioned this pull request Aug 15, 2024
@worstell worstell force-pushed the worstell/20240814-lenient-json branch from a515b13 to 7e1908b Compare August 15, 2024 03:26
@worstell worstell added the run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue label Aug 15, 2024
@worstell worstell force-pushed the worstell/20240814-lenient-json branch 3 times, most recently from 59e9d8b to 4d6c1c4 Compare August 15, 2024 03:47
@worstell worstell force-pushed the worstell/20240814-lenient-json branch from 4d6c1c4 to 7417531 Compare August 15, 2024 03:47
@worstell
Copy link
Contributor Author

just tidy did a number so i recommend filtering out go.mod/go.sum 😅

@worstell worstell added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 1d9a0e3 Aug 15, 2024
69 checks passed
@worstell worstell deleted the worstell/20240814-lenient-json branch August 15, 2024 04:03
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@matt2e matt2e added the approved Marks an already closed PR as approved label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved run-all A PR with this label will run the full set of CI jobs in the PR rather than in the merge queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be strict with ingressed model objects, optionally
3 participants