Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial java <-> go integration test #2339

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

Initial PR that tests simple interop. This will be expanded to cover as many different types and features as possible.

@stuartwdouglas stuartwdouglas requested review from a team and matt2e and removed request for a team August 13, 2024 06:14
@ftl-robot ftl-robot mentioned this pull request Aug 13, 2024
@stuartwdouglas stuartwdouglas marked this pull request as draft August 13, 2024 06:15
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/java-go-stubs branch from da13bd3 to 7e91485 Compare August 13, 2024 06:21
@stuartwdouglas stuartwdouglas marked this pull request as ready for review August 13, 2024 06:21
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/java-go-stubs branch from 7e91485 to 92b43d1 Compare August 13, 2024 07:38
@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@stuartwdouglas
Copy link
Collaborator Author

Ugh, that failure is because the Java artifacts have not been built before running the test, and it is using old cached ones from a previous PR. I need to have a think about how to handle this.

Initial PR that tests simple interop. This will be expanded to cover as many different types and features as possible.
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/java-go-stubs branch from 92b43d1 to d83035d Compare August 13, 2024 10:58
@stuartwdouglas
Copy link
Collaborator Author

For now I am just running the java build the same way the binary is built. It might kinda suck when running from the IDE though needing to do the build each time, at some point we may want an env var or something.

@stuartwdouglas stuartwdouglas added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 907731e Aug 13, 2024
17 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/java-go-stubs branch August 13, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants