Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @bufbuild/protoc-gen-es to v2 #2253

Closed
wants to merge 2 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 5, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@bufbuild/protoc-gen-es (source) 1.10.0 -> 2.0.0 age adoption passing confidence

Release Notes

bufbuild/protobuf-es (@​bufbuild/protoc-gen-es)

v2.0.0

Compare Source

What's new in version 2

To support Protobuf editions, we have to make breaking changes that also affect users of proto2 and proto3. This prompted us to make more extensive changes that take feedback from version 1 into account:

We no longer use classes. Instead, we generate a schema object and a type for every message. To create a new instance, to serialize, and for other concerns, we provide functions. Here is a simple example:

import { create, toBinary } from "@​bufbuild/protobuf";
import { UserSchema } from "./gen/example_pb";

let user = create(UserSchema, {
  firstName: "Homer",
  lastName: "Simpson",
  active: true,
});

const bytes = toBinary(UserSchema, user);

If you use proto3, messages are now plain objects. Files with proto2 and editions use the prototype chain to track field presence.

This approach solves several outstanding issues, such as:

[!TIP]

Take a look at the upgrade guide to learn more.

[!NOTE]

Connect-ES does not support version 2 yet. We will update it shortly.

Contributors

Thanks to @​srikrsna-buf for his contributions to v2!


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from alecthomas as a code owner August 5, 2024 01:05
Copy link
Contributor Author

renovate bot commented Aug 5, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: frontend/package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @connectrpc/[email protected]
npm error Found: @bufbuild/[email protected]
npm error node_modules/@bufbuild/protoc-gen-es
npm error   @bufbuild/protoc-gen-es@"2.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peerOptional @bufbuild/protoc-gen-es@"^1.7.2" from @connectrpc/[email protected]
npm error node_modules/@connectrpc/protoc-gen-connect-es
npm error   @connectrpc/protoc-gen-connect-es@"^1.4.0" from the root project
npm error
npm error Conflicting peer dependency: @bufbuild/[email protected]
npm error node_modules/@bufbuild/protoc-gen-es
npm error   peerOptional @bufbuild/protoc-gen-es@"^1.7.2" from @connectrpc/[email protected]
npm error   node_modules/@connectrpc/protoc-gen-connect-es
npm error     @connectrpc/protoc-gen-connect-es@"^1.4.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-08-05T01_05_09_359Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-08-05T01_05_09_359Z-debug-0.log

@renovate renovate bot requested review from a team and worstell and removed request for a team August 5, 2024 01:05
Copy link
Contributor Author

renovate bot commented Aug 5, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@worstell
Copy link
Contributor

worstell commented Aug 8, 2024

ignoring this update because of this issue

@worstell worstell closed this Aug 8, 2024
Copy link
Contributor Author

renovate bot commented Aug 8, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 2.x releases. But if you manually upgrade to 2.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/bufbuild-protoc-gen-es-2.x branch August 8, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant