Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inject newlines to improve readability of just otel-stream output #2078

Merged
merged 3 commits into from
Jul 16, 2024
Merged

chore: inject newlines to improve readability of just otel-stream output #2078

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6d0867
init
deniseli Jul 15, 2024
efd403a
fix pipe
deniseli Jul 15, 2024
91abb28
cleanup
deniseli Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,13 @@ otel-ui:
# `just otel-dev` with any args you would pass to `ftl dev`. To stop the otel stream, run
# `just otel-stop` in a third terminal tab.
otel-stream:
#!/bin/bash

docker run \
-p {{otelGrpcPort}}:{{otelGrpcPort}} \
-p 55679:55679 \
otel/opentelemetry-collector:0.104.0
otel/opentelemetry-collector:0.104.0 2>&1 | sed 's/\([A-Z].* #\)/\
\1/g'

# Stop the docker container running otel.
otelContainerID := `docker ps -f ancestor=otel/opentelemetry-collector:0.104.0 | tail -1 | cut -d " " -f1`
Expand All @@ -218,6 +221,6 @@ otel-stop:
otel-dev *args:
#!/bin/bash

gprcPort=$(cat docker-compose.yml | grep "OTLP gRPC" | sed 's/:.*//' | sed -r 's/ +- //')
export OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:${gprcPort}"
grpcPort=$(cat docker-compose.yml | grep "OTLP gRPC" | sed 's/:.*//' | sed -r 's/ +- //')
export OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:${grpcPort}"
ftl dev {{args}}
Loading