feat: migrate topics and subscriptions #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
a team and
deniseli
and removed request for
a team
Open
wesbillman
approved these changes
Jul 12, 2024
| return optional.Some(callExpr) | ||
| } | ||
|
|
||
| func FuncPathEquals(pass *analysis.Pass, callExpr *ast.CallExpr, path string) bool { |
There was a problem hiding this comment.
nit: should we add comments to this func and the one above since they're public?
| if _, ok = md.Type.(*schema.Data); !ok && md.Type != nil { | ||
| return optional.None[*schema.Data]() | ||
| } | ||
| common.ApplyMetadata[*schema.Data](pass, named.Obj(), func(md *common.ExtractedMetadata) { |
| varName := topicSelExp.Sel.Name | ||
| topicRef = &schema.Ref{ | ||
| Module: moduleIdent.Name, | ||
| Name: strcase.ToLowerCamel(string(varName[0]) + varName[1:]), |
There was a problem hiding this comment.
is it safe to index into varName here without checking len?
There was a problem hiding this comment.
ah nice catch- i'm not sure, this logic is directly ported. i'll add a check to be safe
worstell
force-pushed
the
worstell/20240712-migrate-topics-subscriptions
branch
from
66a3782 to
73ff666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.