fix: dont mark version as dirty temporarily and investigate git status #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
wesbillman
approved these changes
Jul 9, 2024
Comment on lines
+54
to
+55
| git diff | ||
|
|
There was a problem hiding this comment.
Is this for logging @gak?
There was a problem hiding this comment.
Yes, I need to see what is causing the repo to be dirty.
Comment on lines
+481
to
+487
| type ModuleSecret struct { | ||
| ID int64 | ||
| CreatedAt time.Time | ||
| Module optional.Option[string] | ||
| Name string | ||
| Url string | ||
| } |
There was a problem hiding this comment.
I'm guessing this is unrelated, but needed to be checked in?
There was a problem hiding this comment.
It is related to code generated in the CI causing the repo to be dirty. I'm under the impression these sqlc files needed to be checked in?
There was a problem hiding this comment.
Your impression is correct :) Looks like whoever added ModuleSecret to the db schema just didn't know they needed to run just build-sqlc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.