Bump golang.org/x/net from 0.6.0 to 0.7.0 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](golang/net@v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
alecthomas
approved these changes
Mar 5, 2023
deniseli
added a commit
that referenced
this pull request
Jul 16, 2024
…utput (#2078) Part 3 of #2020 This PR injects newlines between blocks in `just otel-stream`'s docker container output. We should ideally add [color](https://www.unix.com/unix-for-dummies-questions-and-answers/134824-using-sed-change-specific-words-color.html) + bolding to this as well, which can be done by piping to a very similar `sed` command, but moving forward without that for now to save time. Example snippet of the output: ``` Metric #2 Descriptor: -> Name: rpc.server.response.size -> Description: Measures size of RPC response messages (uncompressed). -> Unit: By -> DataType: Histogram -> AggregationTemporality: Cumulative HistogramDataPoints #0 Data point attributes: -> rpc.grpc.status_code: Int(0) -> rpc.method: Str(Ping) -> rpc.service: Str(xyz.block.ftl.v1.VerbService) -> rpc.system: Str(grpc) StartTimestamp: 2024-07-16 00:02:17.426033 +0000 UTC Timestamp: 2024-07-16 00:02:37.427409 +0000 UTC Count: 1 Sum: 0.000000 Min: 0.000000 Max: 0.000000 ExplicitBounds #0: 0.000000 ExplicitBounds #1: 5.000000 ExplicitBounds #2: 10.000000 ```
deniseli
added a commit
that referenced
this pull request
Jul 31, 2024
These are just the basic metrics. Queue depth up-down counters should come next ``` ScopeMetrics #3 ScopeMetrics SchemaURL: InstrumentationScope ftl.async_call Metric #0 Descriptor: -> Name: ftl.async_call.acquired -> Description: the number of times that the controller tries acquiring an async call -> Unit: 1 -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.time_since_scheduled_at_ms: Int(24) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(true) StartTimestamp: 2024-07-31 00:33:53.897947 +0000 UTC Timestamp: 2024-07-31 00:34:08.898478 +0000 UTC Value: 1 Metric #1 Descriptor: -> Name: ftl.async_call.executed -> Description: the number of times that the controller tries executing an async call -> Unit: 1 -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.time_since_scheduled_at_ms: Int(41) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(true) StartTimestamp: 2024-07-31 00:33:53.897952 +0000 UTC Timestamp: 2024-07-31 00:34:08.898485 +0000 UTC Value: 1 Metric #2 Descriptor: -> Name: ftl.async_call.completed -> Description: the number of times that the controller tries completing an async call -> Unit: 1 -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.time_since_scheduled_at_ms: Int(46) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(true) StartTimestamp: 2024-07-31 00:33:53.897956 +0000 UTC Timestamp: 2024-07-31 00:34:08.898487 +0000 UTC Value: 1 ``` When a call fails, it looks like: ``` Metric #1 Descriptor: -> Name: ftl.async_call.executed -> Description: the number of times that the controller tries executing an async call -> Unit: 1 -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.async_call.execution.failure_mode: Str(async call failed) -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.time_since_scheduled_at_ms: Int(16) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(false) StartTimestamp: 2024-07-31 00:41:26.013892 +0000 UTC Timestamp: 2024-07-31 00:41:41.014946 +0000 UTC Value: 1 ``` Issue: #2194 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jonathanj-square
added a commit
that referenced
this pull request
Jul 31, 2024
This change introduces the following runner metrics: * `ftl.runner.startup.failures` * `ftl.runner.registration.heartbeats` * `ftl.runner.failures` Metric output from local run: --- ScopeMetrics #1 ScopeMetrics SchemaURL: InstrumentationScope ftl.runner Metric #0 Descriptor: -> Name: ftl.runner.registration.heartbeats -> Description: the number of successful runner (re-)registrations -> Unit: -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.deployment.key: Str(unknown) -> ftl.runner.state.name: Str(reserved) StartTimestamp: 2024-07-30 23:15:10.131588 +0000 UTC Timestamp: 2024-07-30 23:15:55.135067 +0000 UTC Value: 4 NumberDataPoints #1 Data point attributes: -> ftl.deployment.key: Str(dpl-echo-32feoiv4rvtuqc66) -> ftl.runner.state.name: Str(assigned) StartTimestamp: 2024-07-30 23:15:10.131588 +0000 UTC Timestamp: 2024-07-30 23:15:55.135067 +0000 UTC Value: 39 NumberDataPoints #2 Data point attributes: -> ftl.deployment.key: Str(dpl-time-2qb3im47gl8zgfb0) -> ftl.runner.state.name: Str(assigned) StartTimestamp: 2024-07-30 23:15:10.131588 +0000 UTC Timestamp: 2024-07-30 23:15:55.135067 +0000 UTC Value: 39 NumberDataPoints #3 Data point attributes: -> ftl.deployment.key: Str(unknown) -> ftl.runner.state.name: Str(idle) StartTimestamp: 2024-07-30 23:15:10.131588 +0000 UTC Timestamp: 2024-07-30 23:15:55.135067 +0000 UTC Value: 119 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deniseli
added a commit
that referenced
this pull request
Jul 31, 2024
…_to_complete` (#2221) Printout showing the exact latency value is the same on the counter attr and on the hist metric itself: ``` Metric #2 Descriptor: -> Name: ftl.async_call.completed -> Description: the number of times that the controller tries completing an async call -> Unit: 1 -> DataType: Sum -> IsMonotonic: true -> AggregationTemporality: Cumulative NumberDataPoints #0 Data point attributes: -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.time_since_scheduled_at_ms: Int(39) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(true) StartTimestamp: 2024-07-31 18:54:35.526397 +0000 UTC Timestamp: 2024-07-31 18:55:10.527278 +0000 UTC Value: 1 Metric #3 Descriptor: -> Name: ftl.async_call.ms_to_complete -> Description: duration in ms to complete an async call, from the earliest time it was scheduled to execute -> Unit: ms -> DataType: Histogram -> AggregationTemporality: Cumulative HistogramDataPoints #0 Data point attributes: -> ftl.async_call.origin: Str(sub:echo.sub) -> ftl.async_call.verb.ref: Str(echo.echoSinkOne) -> ftl.module.name: Str(echo) -> ftl.status.succeeded: Bool(true) StartTimestamp: 2024-07-31 18:54:35.526402 +0000 UTC Timestamp: 2024-07-31 18:55:10.527279 +0000 UTC Count: 1 Sum: 39.000000 Min: 39.000000 Max: 39.000000 ``` Issue: #2194
jonathanj-square
added a commit
that referenced
this pull request
Aug 12, 2024
…ce condition. issue #1 the waitgroup used to await event processing completion is not synchronized with event handling completion. The waitgroup has its count synchronously incremented before the event gets published but the down tick is not explicitly synchronized with handler completion. The down tick occurs in `handlePubSubEvent` in response to a `publishEvent` signal - this signals the intention to distribute an event on a topic not the completion. The `subscriptionDidConsumeEvent` is the right event to target. Given the event is dispatched via a goroutine the race condition may or may not trigger failure depending on competition execution timings. issue #2 event synchronization needs to consider the subscription topology in order to account for non-linear event propagation networks remaining issue synchronous event propagation from the subscriber verb is covered but not asynchronous propagation (e.g. a scenario where a verb spawns a goroutine that delays before writing an event to another topic might fire the event after the waitgroup reaches zero)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
Fixes #2285 Register the standard otel database metrics using: https://github.com/XSAM/otelsql Found call sites by grepping for `sql.Open` and skipping all test code. Sample: ``` ScopeMetrics #2 ScopeMetrics SchemaURL: InstrumentationScope github.com/XSAM/otelsql 0.32.0 Metric #0 Descriptor: -> Name: db.sql.latency -> Description: The latency of calls in milliseconds -> Unit: ms -> DataType: Histogram -> AggregationTemporality: Cumulative HistogramDataPoints #0 Data point attributes: -> method: Str(sql.conn.begin_tx) -> status: Str(ok) StartTimestamp: 2024-08-08 23:18:01.011762 +0000 UTC Timestamp: 2024-08-08 23:18:11.012177 +0000 UTC Count: 23 Sum: 17.082795 Min: 0.137584 Max: 3.233917 ``` --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps golang.org/x/net from 0.6.0 to 0.7.0.
Commits
8e2b117http2/hpack: avoid quadratic complexity in hpack decoding547e7edhttp2: avoid referencing ResponseWrite.Write parameter after returning39940adhtml: parse comments per HTML specDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and languageYou can disable automated security fix PRs for this repo from the Security Alerts page.