Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show logs via command palette #1932

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: show logs via command palette #1932

merged 1 commit into from
Jul 2, 2024

Conversation

gak
Copy link
Contributor

@gak gak commented Jul 2, 2024

No description provided.

@gak gak requested a review from alecthomas as a code owner July 2, 2024 17:56
@gak gak requested review from a team and deniseli and removed request for a team July 2, 2024 17:56
@ftl-robot ftl-robot mentioned this pull request Jul 2, 2024
Copy link
Contributor

@deniseli deniseli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment on lines -63 to -64
"command": "ftl.showPanel",
"title": "Show Panel"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove Show Panel? Just confirming since I wasn't sure :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the bug was that it needs to be showLogs instead. I should have been more clear on why I changed it!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh sweet thanks a bunch for the context :)

@alecthomas
Copy link
Collaborator

Aha!

Copy link
Collaborator

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this in my hackathon, but I also want to move all these commands/handlers to a ./commands folder to have this managed in a structured way. Hoping to get a PR with that refactor soon.

@gak gak merged commit 8425df0 into main Jul 2, 2024
45 checks passed
@gak gak deleted the gak/vscode-show-logs branch July 2, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants