feat: introduce types.ftl.go to register sumtypes, which fixes encoding in unit tests
#1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniseli
force-pushed
the
dli/620-sumtype-reg
branch
from
8a88bd9 to
8fa58ec
Compare
Open
deniseli
force-pushed
the
dli/620-sumtype-reg
branch
2 times, most recently
from
7785c2d to
4afcf6c
Compare
alecthomas
approved these changes
Jul 2, 2024
subpackage test add failing integration test move tests up to parent package test passes lint encoding test put main init back rebuild add new gened file to gitignore rm gened file from git fix path simplify fix discover test comment fix
deniseli
force-pushed
the
dli/620-sumtype-reg
branch
from
9ae07d9 to
006c94c
Compare
It's been unintrusive, so good! Though I haven't tried it out in an IDE. Hopefully it works with everyone's workflows... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1577
This change introduces a new generated file
types.ftl.goin the user-defined package itself to make sure sumtype registrations get called when running unit tests.Notes:
subpackagein the test data that is not yet unit tested. Unit tests should be added (identical to the parent package's unit tests) after Can't define enums in sub-packages #1903 is resolved. Some work will also need to be done to extend thetypes.ftl.gogeneration to working on subpackages.mainModuleContext, which means that code now generates not only just the literalmainpackage, but also the conceptual main package's additional artifacts. I couldn't come up with a name that would be better, so it's left as-is in this PR, but please let me know if you think of something better.