feat: templated node creation #1882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds: configs, enums, fsms, secrets, cron, pubsub, and databases
jonathanj-square
requested review from
a team and
deniseli
and removed request for
a team
Open
wesbillman
reviewed
Jun 26, 2024
Comment on lines
27
to
26
| title: 'Which type of node would you like to add', | ||
| const nodeType = await vscode.window.showQuickPick(['verb', 'enum', 'pubsub', 'pubsub:subscription', 'fsm', 'database', 'config:string', 'config:struct', 'secret', 'cron'], { title: 'Which type of node would you like to add', |
There was a problem hiding this comment.
I think we should leave title on a new line here.
| @@ -55,11 +54,11 @@ export const nodeNewCommand = async (item: FtlTreeItem) => { | |||
| editor.revealRange(lastLineRange, vscode.TextEditorRevealType.Default) | |||
| } | |||
|
|
|||
| const snippetForNodeType = (nodeType: string): string => { | |||
| const snippetForNodeType = async (nodeType: string): Promise<string> => { | |||
| //TODO: fill out for all node types. | |||
There was a problem hiding this comment.
We can remove this now that you're filling them out :)
| const name = await vscode.window.showInputBox(inputBoxOptions); | ||
|
|
||
| if (name) { | ||
| return verbSnippetTemplate.replace(/<name>/g, name) |
There was a problem hiding this comment.
We could make verbSnippetTemplate a func that takes in name as an argument
wesbillman
force-pushed
the
hackathon-extension-tree
branch
from
5cb264b to
a52228b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.