feat: add ftl box command tree
#1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two commands: `ftl box build <image>` builds a self-contained Docker container with a set of modules. `ftl box run` runs modules inside an ftl-in-a-box container.
alecthomas
requested review from
safeer,
a team and
deniseli
and removed request for
a team
Open
deniseli
reviewed
Jun 26, 2024
| } | ||
| baseImage := b.BaseImage | ||
| baseImageParts := strings.Split(baseImage, ":") | ||
| if len(baseImageParts) == 2 { |
There was a problem hiding this comment.
Do we need to error if len(baseImageParts) != 2 or is that a valid case?
There was a problem hiding this comment.
I dunno why I did this, I just should just use url.Port() 🤦
jonathanj-square
pushed a commit
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commands:
ftl box build <image>builds a self-contained Docker container with a set of modules.ftl box runruns modules inside an ftl-in-a-box container (currently does nothing).